This repository was archived by the owner on Sep 11, 2024. It is now read-only.
[FEATURE] Add Links to Partner Icons #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ninadvyas
changed the title
src/components/Footer.jsx
Outdated
| > | ||
| {group.map((company) => ( | ||
| <li key={company.name} className="flex"> | ||
| <a href={company.href} target="_blank" title={company.title}> |
Member
There was a problem hiding this comment.
Please use the nextjs link tag!
Contributor
Author
|
@xkrishguptaa I have made changes accordingly as you said. |
kkrishguptaa
suggested changes
Dec 29, 2023
Member
kkrishguptaa
left a comment
kkrishguptaa
left a comment
There was a problem hiding this comment.
Did you import the link tag? Because I do not see it in the imports?
Comment on lines
38
to
46
| <Link href={company.href} target="_blank" title={company.title}> | ||
| <Image | ||
| src={company.logo} | ||
| alt={company.name} | ||
| unoptimized | ||
| width="50" | ||
| /> | ||
| </Link> |
Member
There was a problem hiding this comment.
Suggested change
| <Link href={company.href} target="_blank" title={company.title}> | |
| <Image | |
| src={company.logo} | |
| alt={company.name} | |
| unoptimized | |
| width="50" | |
| /> | |
| </Link> | |
| <Link href={company.href} target="_blank" title={company.title}> | |
| <Image | |
| src={company.logo} | |
| alt={company.name} | |
| unoptimized | |
| width="50" | |
| /> | |
| </Link> |
kkrishguptaa
force-pushed
the
fix#310
branch
from
35a71db to
e49f786
Compare
Contributor
Author
|
@xkrishguptaa link tag already there imported at first line of the file. Waiting for the feedback. |
kkrishguptaa
approved these changes
Dec 29, 2023
Member
kkrishguptaa
left a comment
kkrishguptaa
left a comment
There was a problem hiding this comment.
Ah okay! sorry missed it earlier, thank you for the contribution
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #310Add Links to Partner Icons : #310Changes proposed
Check List (Check all the applicable boxes)
Screenshots of #310