Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@josuembuyu
Copy link
Contributor

@josuembuyu josuembuyu commented Nov 5, 2023

This pull request aims to resolve issue #304, which addresses a problem with the newsletter iframe breaking on the mobile version of the project. To fix this issue, the pull request introduces a "full-width" CSS class to the newsletter iframe, ensuring that it adapts to the mobile screen width.

Fixes Issue

Closes #304

Changes proposed

  • Added a "w-full" tailwind class to the newsletter iframe.
  • Ensured that the iframe now resizes correctly to fit the mobile screen width

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2023-11-05 at 02 24 24

Note to reviewers

@vercel
Copy link

vercel bot commented Nov 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2023 1:36am

Copy link
Member

@kkrishguptaa kkrishguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you so much!

@kkrishguptaa kkrishguptaa merged commit e21ff99 into EddieHubCommunity:main Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newsletter iframe breaks on mobile version

2 participants