-
Notifications
You must be signed in to change notification settings - Fork 16
Complete CCPPization of gravity wave drag #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
…cs does not run here
…ts gw flags; set initial_value for ttend_dp so it persist across bc/ac
|
I brought in the vorticity code from the SE dycore in CAM into this PR to enable the moving mountains GW parameterization in the FCAM7 compset. I think the bug fixes from ESCOMP/CAM#1415 once they're in ESCOMP/CAM need to be ported to CAM-SIMA as well. |
|
I ported the frontogenesis fixes from |
nusbaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing in all of the new gravity wave code @jimmielin! I mostly just have a bunch of nit-picks and style requests, but of course let me know if any request is problematic. Thanks again!
Co-authored-by: Jesse Nusbaumer <[email protected]>
nusbaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me now @jimmielin!
Tag name (required for release branches):
Originator(s): @jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Describe any changes made to build system: N/A
Describe any changes made to the namelist: NLCOMP will fail due to added gamma file
/gw_drag_input_nl/ bnd_rdggmList any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: see below with
AflagList all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: