This repository was archived by the owner on Sep 28, 2022. It is now read-only.
autocomplete: various improvements #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add `@change` event ElemeFE#17913 2. don't prevent when suggestions are not visible ElemeFE#17472 3. allow `fetchSuggestions` returns a promise or an array 4. add `show-all-on-focus` prop 5. use tab for selection like enter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@changeevent添加
@change事件Autocomplete: add change event ElemeFE/element#17913
在备选列表不可见时不要preventDefault键盘事件
AutoComplete: enable keyup&keydown when there is no suggestions ElemeFE/element#17472
fetchSuggestionsreturns a promise or an array允许fetchSuggestions直接返回数组或一个promise对象
show-all-on-focusprop添加
show-all-on-focus属性允许使用tab键选择
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.