Skip to content

Commit f01acd1

Browse files
authored
Merge pull request #186 from bedroge/ingestion_contents_check
Disable tarball content type check in ingestion script
2 parents c297afe + 2606cd2 commit f01acd1

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

scripts/ingest-tarball.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,5 +261,7 @@ is_repo_owner || cvmfs_server="sudo cvmfs_server"
261261
# Do some checks, and ingest the tarball
262262
check_repo_vars
263263
check_version
264-
check_contents_type
264+
# Disable the call to check_contents_type, as it does not work for tarballs produced
265+
# by our build bot that only contain init files (as they have "software" in the filename)
266+
# check_contents_type
265267
ingest_${tar_contents_type_dir}_tarball

scripts/test-ingest-tarball.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ tarballs_success=(
5454
# Test that should return an error
5555
tarballs_fail=(
5656
# Non-matching type dirs
57-
"$tstdir/eessi-2000.01-compat-123456.tar.gz 2000.01 init"
58-
"$tstdir/eessi-2000.01-init-123456.tar.gz 2000.01 initt"
59-
"$tstdir/eessi-2000.01-scripts-123456.tar.gz 2000.01 scriptss"
60-
"$tstdir/eessi-2000.01-software-123456.tar.gz 2000.01 soft"
57+
# They have been disabled, as we removed the content type check in the ingestion script
58+
# "$tstdir/eessi-2000.01-compat-123456.tar.gz 2000.01 init"
59+
# "$tstdir/eessi-2000.01-init-123456.tar.gz 2000.01 initt"
60+
# "$tstdir/eessi-2000.01-scripts-123456.tar.gz 2000.01 scriptss"
61+
# "$tstdir/eessi-2000.01-software-123456.tar.gz 2000.01 soft"
6162
# Non-matching versions
6263
"$tstdir/eessi-2000.01-compat-123456.tar.gz 2000.12 compat"
6364
"$tstdir/eessi-2000.01-init-123456.tar.gz 2000.12 init"
@@ -85,7 +86,7 @@ tarballs_fail=(
8586
# Run the tests that should succeed
8687
for ((i = 0; i < ${#tarballs_success[@]}; i++)); do
8788
t=$(create_tarball ${tarballs_success[$i]})
88-
"${INGEST_SCRIPT}" "$t" > /dev/null
89+
"${INGEST_SCRIPT}" "$t" >& /dev/null
8990
if [ ! $? -eq 0 ]; then
9091
num_tests_failed=$((num_tests_failed + 1))
9192
else

0 commit comments

Comments
 (0)