save task state to local storage #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a merge conflict in the PR, can you have a look? |
lukeecart
force-pushed
the
save-task-state-to-local-storage
branch
from
133136c to
bb26107
Compare
|
That was due to the completed all button. I have resolved that and fix that 👍🏻 |
lukeecart
force-pushed
the
save-task-state-to-local-storage
branch
from
bb26107 to
ec38a93
Compare
|
I rebased from main so if you are checking locally, you'll need to delete a local version and pull the branch again. e.g. |
|
It works great! Looks good to merge, thanks a lot for your contribution 🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a isChecked variable to the task and is used to check that the task is complete or not.
This now means that the state is saved in local storage.