This repository was archived by the owner on Feb 15, 2022. It is now read-only.
Added Binance to Zenbot #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
suggested changes
Dec 4, 2017
|
|
||
| function authedClient () { | ||
| if (!authed_client) { | ||
| if (!c.binance || !c.binance.key || !c.binance.key === 'YOUR-API-KEY') { |
Owner
There was a problem hiding this comment.
if (!c.binance || !c.binance.key || !c.binance.key === 'YOUR-API-KEY') {
This should be:
if (!c.binance || !c.binance.key || c.binance.key === 'YOUR-API-KEY') {
Because if c.binance.key === 'YOUR-API-KEY' we should stop
Repository owner
deleted a comment from
tfossoulw
Dec 4, 2017
Repository owner
deleted a comment
Dec 4, 2017
Contributor
Author
|
@DeviaVir Fixed. |
DeviaVir
approved these changes
Dec 4, 2017
Owner
DeviaVir
left a comment
DeviaVir
left a comment
There was a problem hiding this comment.
👍 cool, thanks for your contribution! Let's see it in the wild.
Contributor
|
Are there options for the API keys in the conf.js? I cant find them |
Owner
|
in the same fashion as all other exchanges you can add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Guys,
Here is the code to make binance work in zenbot. I've tested it in both sim, paper and live. Please contact me on discord if you have any questions.