MINOR: SRE-3422: enable deletion protection on GCP side (#36)

* SRE-3422: run periodic jenkins job to enable deletion protection on sql

* SRE-3422: tflint

Author: ApekshaKhilari

README.md

@@ -20,13 +20,14 @@ This modules creates the following resources:
 |------|---------|
 | terraform | >= 1.0.0 |
 | google | >= 3.18.0, <5.0.0 |
+| random | > 3.0.0 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
 | google | >= 3.18.0, <5.0.0 |
-| random | n/a |
+| random | > 3.0.0 |
 
 ## Inputs
 
@@ -41,7 +42,7 @@ This modules creates the following resources:
 | cloudsql\_availability\_type | The availability type of the Cloud SQL instance, high availability (REGIONAL) or single zone (ZONAL). | `string` | `"REGIONAL"` | no |
 | database\_flags | List of Cloud SQL flags that are applied to the database server. See [more details](https://cloud.google.com/sql/docs/mysql/flags) | <pre>list(object({<br>    name  = string<br>    value = string<br>  }))</pre> | `[]` | no |
 | db\_name | name of the database | `string` | `"doit"` | no |
-| deletion\_protection | Set deletion protection on Cloud SQL instance. Unless this field is set to false, a terraform destroy or terraform apply command that deletes the instance will fail. | `bool` | `true` | no |
+| deletion\_protection | Set deletion protection on Cloud SQL instance. Setting this will protect instances from accidental deletion across all surfaces (API, gcloud, Cloud Console and Terraform). | `bool` | `true` | no |
 | disk\_autoresize | Enable disk to autoresize itself | `bool` | `true` | no |
 | disk\_size | size of the disk to use | `number` | `100` | no |
 | disk\_type | The disk type to use on the instance. should be either PD\_SSD or PD\_STANDARD | `string` | `"PD_SSD"` | no |

examples/minimal/README.md

@@ -21,13 +21,14 @@ resource "google_sql_database_instance" "tamr" {
   }
 
   settings {
-    tier              = var.tier
-    disk_size         = var.disk_size
-    disk_type         = var.disk_type
-    activation_policy = var.activation_policy
-    disk_autoresize   = var.disk_autoresize
-    user_labels       = var.labels
-    availability_type = var.cloudsql_availability_type
+    tier                        = var.tier
+    disk_size                   = var.disk_size
+    disk_type                   = var.disk_type
+    activation_policy           = var.activation_policy
+    disk_autoresize             = var.disk_autoresize
+    user_labels                 = var.labels
+    availability_type           = var.cloudsql_availability_type
+    deletion_protection_enabled = var.deletion_protection
 
     dynamic "backup_configuration" {
       for_each = var.backup_enabled ? ["true"] : []

examples/minimal/main.tf

@@ -97,7 +97,7 @@ variable "database_flags" {
 
 variable "deletion_protection" {
   type        = bool
-  description = "Set deletion protection on Cloud SQL instance. Unless this field is set to false, a terraform destroy or terraform apply command that deletes the instance will fail."
+  description = "Set deletion protection on Cloud SQL instance. Setting this will protect instances from accidental deletion across all surfaces (API, gcloud, Cloud Console and Terraform)."
   default     = true
 }
 

examples/minimal/variables.tf

@@ -5,5 +5,9 @@ terraform {
       source  = "hashicorp/google"
       version = ">= 3.18.0, <5.0.0"
     }
+    random = {
+      source  = "hashicorp/random"
+      version = "> 3.0.0"
+    }
   }
 }