Skip to content

Commit 4095f79

Browse files
CA-161 - Update S3 module to prevent installing aws provider 4.0 (#12)
* Adds *.tfvars and *.terraform.lock.hcl to gitignore file. * Updates version file to prevent the installing provider version 4.0. * Updates version file to prevent installing aws provider version 4.0. * Adds tfsec ignore comment for AWS077 and AWS098. * Updates ignore section.
1 parent 8c6a0f4 commit 4095f79

File tree

6 files changed

+15
-4
lines changed

6 files changed

+15
-4
lines changed

.gitignore

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Local .terraform directories
22
**/.terraform/*
33

4+
5+
# Terraform module lock files
6+
*.terraform.lock.hcl
7+
48
# .tfstate files
59
*.tfstate
610
*.tfstate.*
@@ -37,3 +41,6 @@ terratest.tf.json
3741

3842
# Ignore makefile
3943
ops-makefile
44+
45+
# Ignore tfvars
46+
**/*.tfvars

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Tamr S3 Module Repo
22

3+
## v1.1.1 - February 12th 2022
4+
* Updates version file to prevent the major upgrade to the AWS provider version 4.0.
5+
36
## v1.1.0 - July 12nd 2021
47
* Adds tags for IAM policies
58
* Adds new variable `tags` to set tags for all resources

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ This modules creates:
3737
| Name | Version |
3838
|------|---------|
3939
| terraform | >= 0.13 |
40-
| aws | >= 3.36.0 |
40+
| aws | >= 3.36.0, < 4.0.0 |
4141

4242
## Providers
4343

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.1.0
1+
1.1.1

modules/encrypted-bucket/main.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
resource "aws_s3_bucket" "new_bucket" { #tfsec:ignore:AWS002
1+
#tfsec:ignore:aws-s3-enable-bucket-logging tfsec:ignore:aws-s3-enable-versioning tfsec:ignore:aws-s3-specify-public-access-block
2+
resource "aws_s3_bucket" "new_bucket" {
23
bucket = var.bucket_name
34
acl = "private"
45

versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
terraform {
22
required_version = ">= 0.13"
33
required_providers {
4-
aws = ">= 3.36.0"
4+
aws = ">= 3.36.0, < 4.0.0"
55
}
66
}

0 commit comments

Comments
 (0)