OWR*.206: Variable checks, improved cold-boot, other fixes

matmacieje · matmacieje · commit 8feebcb639c4 · 2025-10-15T13:20:47.000+02:00
rtcwake static binary now provided via cloud download, simplified
Download File kw added to lib/openwrt.robot

Signed-off-by: Mateusz Maciejewski &lt;mateusz.maciejewski@3mdeb.com&gt;
diff --git a/dasharo-compatibility/os-openwrt.robot b/dasharo-compatibility/os-openwrt.robot
@@ -21,32 +21,35 @@ Test Setup          Run Keyword
 Default Tags        semiauto
 
 
-*** Variables ***
-${OPENWRT_IMAGE_LINK}=              https://cloud.3mdeb.com/public.php/dav/files/nfC3WGaqCCzHmck
-${OPENWRT_IMAGE_FILE}=              openwrt_combined_efi.img
-${OPENWRT_TARGET_DEVICE}=           nvme0n1
-${OPENWRT_ETHERNET_CONTROLLER}=     Intel Corporation Ethernet Controller
-
-
 *** Test Cases ***
 OWR001.206 Install operating system on disk (OpenWrt)
     [Documentation]    This test installs OpenWrt on NVMe drive using dd program.
     ...    DTS is boot via iPXE and OpenWrt image is downloaded using wget.
     ...    OPENWRT_IMAGE_LINK - image link to download via wget
     ...    OPENWRT_IMAGE_FILE - core of file name
     ...    OPENWRT_TARGET_DEVICE - target drive to be wiped out using dd (!)
+    [Tags]    semiauto
+    Skip If    not ${TESTS_IN_OPENWRT_SUPPORT}    OWR001.206 not supported
+    Variable Should Exist    ${OPENWRT_TARGET_DEVICE}
+    Variable Should Exist    ${OPENWRT_IMAGE_LINK}
+    Variable Should Exist    ${OPENWRT_IMAGE_FILE}
+    ${selection}=    Get Selection From User
+    ...    Caution! You are about to install OpenWrt on ${OPENWRT_TARGET_DEVICE} device. Are you sure?
+    ...    Yes, I'd like to wipe all the data existing on ${OPENWRT_TARGET_DEVICE} device.
+    ...    No, let's skip OpenWrt installation.
+    ${contains_yes}=    Run Keyword And Return Status    Should Contain    ${selection}    Yes, I'd like to
+    Skip If    not(${contains_yes})    OpenWrt installation on ${OPENWRT_TARGET_DEVICE} device skipped.
     Power On
     Make Sure That Network Boot Is Enabled
     Boot Dasharo Tools Suite    iPXE
     Enter Shell In DTS
     VAR    ${openwrt_image_gz}=    ${OPENWRT_IMAGE_FILE}    .gz    separator=${EMPTY}
     Remove File    ${openwrt_image_gz}
     Remove File    ${OPENWRT_IMAGE_FILE}
-    Download File    ${OPENWRT_IMAGE_LINK}    ${openwrt_image_gz}
-    Execute Linux Command    gunzip ${openwrt_image_gz}
-    Execute Linux Command    dd if=${OPENWRT_IMAGE_FILE} of=/dev
+    Download File OpenWrt    ${OPENWRT_IMAGE_LINK}    ${openwrt_image_gz}
+    Execute Linux Command    gunzip ${openwrt_image_gz} | dd of=/dev/${OPENWRT_TARGET_DEVICE} bs=1M
     Execute Linux Command    sync
-    Power On
+    Execute Reboot Command
     Boot OpenWrt
     # Disabling DHCP server of OpenWrt
     Execute Command In Terminal    /etc/init.d/odhcpd disable
@@ -58,13 +61,15 @@ OWR001.206 Install operating system on disk (OpenWrt)
 
 OWR002.206 Boot operating system from disk (OpenWrt)
     [Documentation]    Boot installed OpenWrt from NVMe drive, check identity.
+    Skip If    not ${TESTS_IN_OPENWRT_SUPPORT}    OWR002.206 not supported
     Power On
     Boot OpenWrt
     ${out}=    Execute Command In Terminal    uname -a
     Should Contain    ${out}    OpenWrt
 
 OWR003.206 Boot operating system from disk after cold-boot (OpenWrt)
     [Documentation]    Boot OpenWrt from hard disk after cold-boot.
+    Skip If    not ${TESTS_IN_OPENWRT_SUPPORT}    OWR003.206 not supported
     VAR    @{supported_power_ctrls}=    RteCtrl    sonoff
     Skip If    '${POWER_CTRL}' not in ${supported_power_ctrls}
     Power On
@@ -78,10 +83,12 @@ OWR003.206 Boot operating system from disk after cold-boot (OpenWrt)
 
 OWR004.206 Boot operating system from disk after warm-boot (OpenWrt)
     [Documentation]    Boot OpenWrt from hard disk after warm-boot.
+    Skip If    not ${TESTS_IN_OPENWRT_SUPPORT}    OWR004.206 not supported
     Power On
     Boot OpenWrt
-    Execute Command In Terminal    poweroff
-    Power On
+    Download File OpenWrt    https://cloud.3mdeb.com/public.php/dav/files/Aqe5Xj24pkoYLwX    /bin/rtcwake
+    Execute Command In Terminal    chmod +x /bin/rtcwake
+    Perform Warmboot Using Rtcwake
     ${start_date}=    Get Current Date
     Boot OpenWrt
     ${end_date}=    Get Current Date
@@ -90,6 +97,7 @@ OWR004.206 Boot operating system from disk after warm-boot (OpenWrt)
 
 OWR005.206 Boot operating system from disk after reboot (OpenWrt)
     [Documentation]    Boot OpenWrt from hard disk after reboot.
+    Skip If    not ${TESTS_IN_OPENWRT_SUPPORT}    OWR005.206 not supported
     Power On
     Boot OpenWrt
     Execute Command In Terminal    reboot
@@ -101,6 +109,7 @@ OWR005.206 Boot operating system from disk after reboot (OpenWrt)
 
 OWR006.206 Scan WiFi networks (OpenWrt)
     [Documentation]    Enable WiFi and scan for 3mdeb lab network.
+    Skip If    not ${TESTS_IN_OPENWRT_SUPPORT}    OWR006.206 not supported
     Power On
     Boot OpenWrt
     Enable WiFi OpenWrt
@@ -109,6 +118,8 @@ OWR006.206 Scan WiFi networks (OpenWrt)
 OWR007.206 Ethernet controller detection (OpenWrt)
     [Documentation]    Check presence of ethernet controller using lspci.
     ...    Install pciutils if missing. Controller name defined in OPENWRT_ETHERNET_CONTROLLER.
+    Skip If    not ${TESTS_IN_OPENWRT_SUPPORT}    OWR007.206 not supported
+    Variable Should Exist    ${OPENWRT_ETHERNET_CONTROLLER}
     Power On
     Boot OpenWrt
     Detect Or Install Package OpenWrt    pciutils
diff --git a/lib/openwrt.robot b/lib/openwrt.robot
@@ -4,11 +4,6 @@ Resource    ../keywords.robot
 Resource    ../lib/platform/power.robot
 
 
-*** Variables ***
-${OPENWRT_WIFI_UP_ATTEMPTS}=        512
-${OPENWRT_WIFI_SCAN_ATTEMPTS}=      8
-
-
 *** Keywords ***
 Boot OpenWrt
     [Documentation]    Boot OpenWrt using Boot From File, kernel -> /efi/boot/bootx64.efi
@@ -40,6 +35,7 @@ Enable WiFi OpenWrt
     [Documentation]    Enabling WiFi in OpenWrt with uci. Setting it up and
     ...    waiting for wifi status output to be "up".
     ...    Number of attempts defined in OPENWRT_WIFI_UP_ATTEMPTS.
+    Variable Should Exist    ${OPENWRT_WIFI_UP_ATTEMPTS}
     ${out_show}=    Execute Command In Terminal    uci show wireless
     Should Contain    ${out_show}    wireless.radio0=wifi-device
     Execute Command In Terminal    uci set wireless.radio0.country='PL'
@@ -63,6 +59,7 @@ Scan WiFi For Network OpenWrt
     [Documentation]    Sanning for WiFi network named by ESSID. Interface name extracted
     ...    from wifi status command output. Number of attempts defined in OPENWRT_WIFI_SCAN_ATTEMPTS.
     [Arguments]    ${essid}
+    Variable Should Exist    ${OPENWRT_WIFI_SCAN_ATTEMPTS}
     VAR    @{empty_list}=    @{EMPTY}
     ${ifname_grep}=    Execute Command In Terminal    wifi status | grep "ifname"
     ${re_search}=    Get Regexp Matches    ${ifname_grep}    (\\s*)(\"ifname\":\\s*)\"([^"]*)\",    3
@@ -73,3 +70,14 @@ Scan WiFi For Network OpenWrt
         Pass Execution If    ${contains} == ${TRUE}    ${essid} network found in ${index} attempt(s).
     END
     Fail    Searching for ${essid} network failed in ${OPENWRT_WIFI_SCAN_ATTEMPTS} attempts.
+
+Download File OpenWrt
+    [Documentation]    Download file from the given URL.
+    [Arguments]    ${remote_url}    ${local_path}    ${timeout}=30
+    Wait Until Keyword Succeeds    5x    1s
+    ...    Check Internet Connection On Linux
+    ${out}=    Execute Linux Command
+    ...    wget --no-check-certificate -O ${local_path} ${remote_url}
+    ...    ${timeout}
+    Should Contain    ${out}    ${local_path}
+    Should Not Contain    ${out}    failed
diff --git a/platform-configs/include/default.robot b/platform-configs/include/default.robot
@@ -85,6 +85,7 @@ ${TESTS_IN_WINDOWS_SUPPORT}=                        ${FALSE}
 ${TESTS_IN_METATB_SUPPORT}=                         ${FALSE}
 ${TESTS_IN_HEADS_SUPPORT}=                          ${FALSE}
 ${TESTS_IN_FEDORA_SUPPORT}=                         ${FALSE}
+${TESTS_IN_OPENWRT_SUPPORT}=                        ${FALSE}
 
 # Regression test flags
 ${DASHARO_SECURITY_MENU_SUPPORT}=                   ${FALSE}
@@ -262,6 +263,14 @@ ${CAPSULE_UPDATE_SUPPORT}=                          ${FALSE}
 # Test module: trenchboot
 ${TRENCHBOOT_SUPPORT}=                              ${FALSE}
 
+# OpenWRT-specific variables
+${OPENWRT_IMAGE_LINK}=                              ${TBD}
+${OPENWRT_IMAGE_FILE}=                              ${TBD}
+${OPENWRT_TARGET_DEVICE}=                           ${TBD}
+${OPENWRT_ETHERNET_CONTROLLER}=                     ${TBD}
+${OPENWRT_WIFI_UP_ATTEMPTS}=                        ${TBD}
+${OPENWRT_WIFI_SCAN_ATTEMPTS}=                      ${TBD}
+
 # Test cases iterations number
 # Booting OS from USB stick test cases
 ${BOOT_FROM_USB_ITERATIONS_NUMBER}=                 0
diff --git a/platform-configs/include/protectli-common.robot b/platform-configs/include/protectli-common.robot
@@ -42,6 +42,7 @@ ${TESTS_IN_FIRMWARE_SUPPORT}=                   ${TRUE}
 ${TESTS_IN_UBUNTU_SUPPORT}=                     ${TRUE}
 ${TESTS_IN_WINDOWS_SUPPORT}=                    ${TRUE}
 ${TESTS_IN_ESXI_SUPPORT}=                       ${TRUE}
+${TESTS_IN_OPENWRT_SUPPORT}=                    ${TRUE}
 
 # Regression test flags
 ${DASHARO_USB_MENU_SUPPORT}=                    ${TRUE}
@@ -142,6 +143,14 @@ ${STABILITY_DETECTION_WARMBOOT_ITERATIONS}=     2
 ${STABILITY_DETECTION_REBOOT_ITERATIONS}=       5
 ${STABILITY_DETECTION_SUSPEND_ITERATIONS}=      5
 
+# OpenWRT-specific variables
+${OPENWRT_IMAGE_LINK}=                          https://cloud.3mdeb.com/public.php/dav/files/nfC3WGaqCCzHmck
+${OPENWRT_IMAGE_FILE}=                          openwrt_combined_efi.img
+${OPENWRT_TARGET_DEVICE}=                       nvme0n1
+${OPENWRT_ETHERNET_CONTROLLER}=                 Intel Corporation Ethernet Controller
+${OPENWRT_WIFI_UP_ATTEMPTS}=                    512
+${OPENWRT_WIFI_SCAN_ATTEMPTS}=                  8
+
 
 *** Keywords ***
 Power On
