Skip to content

Commit bda2299

Browse files
committed
Rename Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap
TC39 decided to rename them to avoid web-compat issue[1]. This change follows to it. [1]: tc39/proposal-array-grouping#39
1 parent 10a5c4f commit bda2299

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

features.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ ShadowRealm
260260
# https://github.com/tc39/proposal-array-find-from-last
261261
array-find-from-last
262262

263-
# Array.prototype.groupBy & Array.prototype.groupByToMap
263+
# Array.prototype.group & Array.prototype.groupToMap
264264
# https://github.com/tc39/proposal-array-grouping
265265
array-grouping
266266

test/built-ins/Array/prototype/Symbol.unscopables/array-grouping.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ info: |
88
22.1.3.32 Array.prototype [ @@unscopables ]
99
1010
...
11-
10. Perform ! CreateDataPropertyOrThrow(unscopableList, "groupBy", true).
12-
11. Perform ! CreateDataPropertyOrThrow(unscopableList, "groupByToMap", true).
11+
10. Perform ! CreateDataPropertyOrThrow(unscopableList, "group", true).
12+
11. Perform ! CreateDataPropertyOrThrow(unscopableList, "groupToMap", true).
1313
...
1414
1515
includes: [propertyHelper.js]
@@ -20,12 +20,12 @@ var unscopables = Array.prototype[Symbol.unscopables];
2020

2121
assert.sameValue(Object.getPrototypeOf(unscopables), null);
2222

23-
assert.sameValue(unscopables.groupBy, true, '`groupBy` property value');
24-
verifyEnumerable(unscopables, 'groupBy');
25-
verifyWritable(unscopables, 'groupBy');
26-
verifyConfigurable(unscopables, 'groupBy');
23+
assert.sameValue(unscopables.group, true, '`group` property value');
24+
verifyEnumerable(unscopables, 'group');
25+
verifyWritable(unscopables, 'group');
26+
verifyConfigurable(unscopables, 'group');
2727

28-
assert.sameValue(unscopables.groupByToMap, true, '`groupByToMap` property value');
29-
verifyEnumerable(unscopables, 'groupByToMap');
30-
verifyWritable(unscopables, 'groupByToMap');
31-
verifyConfigurable(unscopables, 'groupByToMap');
28+
assert.sameValue(unscopables.groupToMap, true, '`groupToMap` property value');
29+
verifyEnumerable(unscopables, 'groupToMap');
30+
verifyWritable(unscopables, 'groupToMap');
31+
verifyConfigurable(unscopables, 'groupToMap');

0 commit comments

Comments
 (0)