Merge pull request #370 from Commencis/chore/eslint-config-commencis-v2

ymehmetcan · web-flow · commit a2e5765a656e · 2025-08-24T22:37:58.000+03:00
feat: update consistent type imports
diff --git a/.changeset/odd-boats-create.md b/.changeset/odd-boats-create.md
@@ -0,0 +1,8 @@
+---
+'@commencis/lint-staged-config': minor
+'@commencis/stylelint-config': minor
+'@commencis/eslint-config': minor
+'@commencis/eslint-plugin': minor
+---
+
+feat: update consistent type imports
diff --git a/package.json b/package.json
@@ -48,7 +48,7 @@
   "devDependencies": {
     "@changesets/cli": "2.29.6",
     "@commencis/commitlint-config": "1.1.4",
-    "@commencis/eslint-config": "1.7.5",
+    "@commencis/eslint-config": "2.0.0",
     "@commencis/lint-staged-config": "1.0.0",
     "@commencis/prettier-config": "2.0.0",
     "@commencis/ts-config": "0.0.2",
diff --git a/packages/eslint-config/src/configs/next.ts b/packages/eslint-config/src/configs/next.ts
@@ -1,4 +1,4 @@
-import { type FlatConfigArray } from '@/types';
+import type { FlatConfigArray } from '@/types';
 
 import baseConfig from '@/configs/base';
 import prettierConfig from '@/configs/prettier';
diff --git a/packages/eslint-config/src/configs/typescript.ts b/packages/eslint-config/src/configs/typescript.ts
@@ -1,6 +1,6 @@
 import tseslint from 'typescript-eslint';
 
-import { type FlatConfigArray } from '@/types';
+import type { FlatConfigArray } from '@/types';
 
 import { typescriptRules } from '@/rules';
 
diff --git a/packages/eslint-config/src/configs/vue.ts b/packages/eslint-config/src/configs/vue.ts
@@ -1,6 +1,6 @@
 import tseslint from 'typescript-eslint';
 
-import { type FlatConfigArray } from '@/types';
+import type { FlatConfigArray } from '@/types';
 
 import baseConfig from '@/configs/base';
 import prettierConfig from '@/configs/prettier';
diff --git a/packages/eslint-config/src/plugins/importSortPlugin.ts b/packages/eslint-config/src/plugins/importSortPlugin.ts
@@ -1,8 +1,9 @@
 import simpleImportSortPlugin from 'eslint-plugin-simple-import-sort';
 
-import { importSortRules } from '@/rules';
 import type { FlatConfig } from '@/types';
 
+import { importSortRules } from '@/rules';
+
 export const importSortPluginConfig: FlatConfig = {
   name: 'commencis/plugin:simple-import-sort',
   plugins: {
diff --git a/packages/eslint-config/src/plugins/jsxA11yPlugin.ts b/packages/eslint-config/src/plugins/jsxA11yPlugin.ts
@@ -1,7 +1,7 @@
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
 
+import type { FlatConfig } from '@/types';
 import { JSX_TSX_FILE_PATTERNS } from '@/constants';
-import { type FlatConfig } from '@/types';
 
 export const jsxA11yPluginConfig: FlatConfig = {
   name: 'commencis/plugin:jsx-a11y',
diff --git a/packages/eslint-config/src/plugins/nextPlugin.ts b/packages/eslint-config/src/plugins/nextPlugin.ts
@@ -1,7 +1,7 @@
 import nextPlugin from '@next/eslint-plugin-next';
 
+import type { FlatConfig } from '@/types';
 import { JSX_TSX_FILE_PATTERNS } from '@/constants';
-import { type FlatConfig } from '@/types';
 
 import { nextPluginRules } from '@/rules';
 
diff --git a/packages/eslint-config/src/plugins/reactHooksPlugin.ts b/packages/eslint-config/src/plugins/reactHooksPlugin.ts
@@ -1,7 +1,7 @@
 import reactHooksPlugin from 'eslint-plugin-react-hooks';
 
+import type { FlatConfig } from '@/types';
 import { JSX_TSX_FILE_PATTERNS } from '@/constants';
-import { type FlatConfig } from '@/types';
 
 import { reactHooksRules } from '@/rules';
 
diff --git a/packages/eslint-config/src/plugins/reactPlugin.ts b/packages/eslint-config/src/plugins/reactPlugin.ts
@@ -1,7 +1,7 @@
 import reactPlugin from 'eslint-plugin-react';
 
+import type { FlatConfig } from '@/types';
 import { JSX_TSX_FILE_PATTERNS } from '@/constants';
-import { type FlatConfig } from '@/types';
 
 import { reactRules } from '@/rules';
 
diff --git a/packages/eslint-config/src/plugins/vuePlugin.ts b/packages/eslint-config/src/plugins/vuePlugin.ts
@@ -1,6 +1,6 @@
 import vuePlugin from 'eslint-plugin-vue';
 
-import { FlatConfigArray } from '@/types';
+import type { FlatConfigArray } from '@/types';
 
 export const vuePluginConfig: FlatConfigArray = [
   ...vuePlugin.configs['flat/recommended'],
diff --git a/packages/eslint-config/src/rules/importSortRules.ts b/packages/eslint-config/src/rules/importSortRules.ts
@@ -69,7 +69,7 @@ const GROUPS: Record<string, string[]> = {
   ]),
 
   // Internal root alias (catch-all leftover @/ imports)
-  INTERNAL_ROOT: [exact(''), subpath('')],
+  INTERNAL_ROOT: ['^@/.+$'],
 
   // Relative parent imports then same-dir relatives
   RELATIVE_PARENT: ['^\\.\\.(?!/?$)', '^\\.\\./?$'],
diff --git a/packages/eslint-config/src/rules/nextPluginRules.ts b/packages/eslint-config/src/rules/nextPluginRules.ts
@@ -1,4 +1,4 @@
-import { Linter } from '@typescript-eslint/utils/ts-eslint';
+import type { Linter } from '@typescript-eslint/utils/ts-eslint';
 
 export const nextPluginRules: Linter.RulesRecord = {
   // Breaks with ESLint 9, should be activated after the next plugin is updated
diff --git a/packages/eslint-config/src/rules/reactHooksRules.ts b/packages/eslint-config/src/rules/reactHooksRules.ts
@@ -1,4 +1,4 @@
-import { Linter } from '@typescript-eslint/utils/ts-eslint';
+import type { Linter } from '@typescript-eslint/utils/ts-eslint';
 
 export const reactHooksRules: Linter.RulesRecord = {
   'react-hooks/exhaustive-deps': 'warn',
diff --git a/packages/eslint-config/src/rules/reactRules.ts b/packages/eslint-config/src/rules/reactRules.ts
@@ -1,4 +1,4 @@
-import { Linter } from '@typescript-eslint/utils/ts-eslint';
+import type { Linter } from '@typescript-eslint/utils/ts-eslint';
 
 export const reactRules: Linter.RulesRecord = {
   // Disable JS specific rules
diff --git a/packages/eslint-config/src/rules/typescriptRules.ts b/packages/eslint-config/src/rules/typescriptRules.ts
@@ -5,8 +5,14 @@ export const typescriptRules: Linter.RulesRecord = {
   '@typescript-eslint/no-empty-function': 'off',
   '@typescript-eslint/array-type': 'off',
 
-  '@typescript-eslint/consistent-type-imports': 'error',
   '@typescript-eslint/explicit-function-return-type': 'error',
+  '@typescript-eslint/consistent-type-imports': [
+    'error',
+    {
+      prefer: 'type-imports',
+      fixStyle: 'separate-type-imports',
+    },
+  ],
   '@typescript-eslint/no-unused-vars': [
     'error',
     {
diff --git a/packages/eslint-plugin/src/configs/all.ts b/packages/eslint-plugin/src/configs/all.ts
@@ -1,4 +1,4 @@
-import { Linter } from '@typescript-eslint/utils/ts-eslint';
+import type { Linter } from '@typescript-eslint/utils/ts-eslint';
 
 export const all: Linter.RulesRecord = {
   '@commencis/copyright-text': 'error',
diff --git a/packages/eslint-plugin/src/configs/recommended.ts b/packages/eslint-plugin/src/configs/recommended.ts
@@ -1,4 +1,4 @@
-import { Linter } from '@typescript-eslint/utils/ts-eslint';
+import type { Linter } from '@typescript-eslint/utils/ts-eslint';
 
 export const recommended: Linter.RulesRecord = {
   '@commencis/copyright-text': 'off',
diff --git a/packages/eslint-plugin/src/index.ts b/packages/eslint-plugin/src/index.ts
@@ -1,10 +1,10 @@
 import type { Linter } from '@typescript-eslint/utils/ts-eslint';
 
+import packageJson from '../package.json';
+
 import { all, recommended } from '@/configs';
 import rules from '@/rules';
 
-import packageJson from '../package.json';
-
 const plugin = {
   meta: {
     name: packageJson.name,
diff --git a/packages/eslint-plugin/src/rules/copyright-text.ts b/packages/eslint-plugin/src/rules/copyright-text.ts
@@ -1,4 +1,4 @@
-import { TSESTree } from '@typescript-eslint/utils';
+import type { TSESTree } from '@typescript-eslint/utils';
 
 import { DEFAULT_START_YEAR } from '@/constants';
 import {
diff --git a/packages/eslint-plugin/src/utils/validateCommencisCopyright.ts b/packages/eslint-plugin/src/utils/validateCommencisCopyright.ts
@@ -1,4 +1,4 @@
-import { AST_TOKEN_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_TOKEN_TYPES, type TSESTree } from '@typescript-eslint/utils';
 
 export function validateCommencisCopyright(
   comment?: TSESTree.Comment | string
diff --git a/packages/lint-staged-config/src/configs/base.ts b/packages/lint-staged-config/src/configs/base.ts
@@ -1,4 +1,4 @@
-import { Configuration } from 'lint-staged';
+import type { Configuration } from 'lint-staged';
 
 import { JSON, MDX } from '@/constants';
 import { PRETTIER } from '@/helpers';
diff --git a/packages/lint-staged-config/src/configs/next.ts b/packages/lint-staged-config/src/configs/next.ts
@@ -1,4 +1,4 @@
-import { Configuration } from 'lint-staged';
+import type { Configuration } from 'lint-staged';
 
 import { SCSS } from '@/constants';
 import { STYLELINT } from '@/helpers';
diff --git a/packages/lint-staged-config/src/configs/react-native.ts b/packages/lint-staged-config/src/configs/react-native.ts
@@ -1,4 +1,4 @@
-import { Configuration } from 'lint-staged';
+import type { Configuration } from 'lint-staged';
 
 import { typescriptConfig } from './typescript';
 
diff --git a/packages/lint-staged-config/src/configs/react.ts b/packages/lint-staged-config/src/configs/react.ts
@@ -1,4 +1,4 @@
-import { Configuration } from 'lint-staged';
+import type { Configuration } from 'lint-staged';
 
 import { SCSS } from '@/constants';
 import { STYLELINT } from '@/helpers';
diff --git a/packages/lint-staged-config/src/configs/typescript.ts b/packages/lint-staged-config/src/configs/typescript.ts
@@ -1,4 +1,4 @@
-import { Configuration } from 'lint-staged';
+import type { Configuration } from 'lint-staged';
 
 import { JSX_TSX } from '@/constants';
 import { ESLINT } from '@/helpers';
diff --git a/packages/lint-staged-config/src/configs/vue.ts b/packages/lint-staged-config/src/configs/vue.ts
@@ -1,4 +1,4 @@
-import { Configuration } from 'lint-staged';
+import type { Configuration } from 'lint-staged';
 
 import { SCSS, VUE } from '@/constants';
 import { ESLINT, STYLELINT } from '@/helpers';
diff --git a/packages/stylelint-config/src/configs/css-modules.ts b/packages/stylelint-config/src/configs/css-modules.ts
@@ -1,9 +1,9 @@
-import { StylelintConfig } from '@/types';
-
-import { cssModulesRules } from '@/rules';
+import type { StylelintConfig } from '@/types';
 
 import cssConfig from './css';
 
+import { cssModulesRules } from '@/rules';
+
 const cssModulesConfig: StylelintConfig = {
   ...cssConfig,
   overrides: [
diff --git a/packages/stylelint-config/src/configs/css.ts b/packages/stylelint-config/src/configs/css.ts
@@ -1,4 +1,4 @@
-import { StylelintConfig } from '@/types';
+import type { StylelintConfig } from '@/types';
 
 import { cssRules, orderRules } from '@/rules';
 import { stylisticRules } from '@/rules/stylisticRules';
diff --git a/packages/stylelint-config/src/configs/scss-modules.ts b/packages/stylelint-config/src/configs/scss-modules.ts
@@ -1,9 +1,9 @@
-import { StylelintConfig } from '@/types';
-
-import { cssModulesRules, scssModulesRules } from '@/rules';
+import type { StylelintConfig } from '@/types';
 
 import scssConfig from './scss';
 
+import { cssModulesRules, scssModulesRules } from '@/rules';
+
 const scssModulesConfig: StylelintConfig = {
   ...scssConfig,
   overrides: [
diff --git a/packages/stylelint-config/src/configs/scss.ts b/packages/stylelint-config/src/configs/scss.ts
@@ -1,4 +1,4 @@
-import { StylelintConfig } from '@/types';
+import type { StylelintConfig } from '@/types';
 
 import { cssRules, orderRules, scssRules } from '@/rules';
 import { stylisticRules } from '@/rules/stylisticRules';
diff --git a/packages/stylelint-config/src/configs/styled.ts b/packages/stylelint-config/src/configs/styled.ts
@@ -1,4 +1,4 @@
-import { StylelintConfig } from '@/types';
+import type { StylelintConfig } from '@/types';
 
 import { cssRules, orderRules, styledRules } from '@/rules';
 
diff --git a/packages/stylelint-config/src/configs/vue-scss.ts b/packages/stylelint-config/src/configs/vue-scss.ts
@@ -1,9 +1,9 @@
-import { StylelintConfig } from '@/types';
-
-import { vueCssRules, vueScssRules } from '@/rules';
+import type { StylelintConfig } from '@/types';
 
 import scssConfig from './scss';
 
+import { vueCssRules, vueScssRules } from '@/rules';
+
 const vueScssConfig: StylelintConfig = {
   ...scssConfig,
   overrides: [
diff --git a/packages/stylelint-config/src/configs/vue.ts b/packages/stylelint-config/src/configs/vue.ts
@@ -1,9 +1,9 @@
-import { StylelintConfig } from '@/types';
-
-import { vueCssRules } from '@/rules';
+import type { StylelintConfig } from '@/types';
 
 import cssConfig from './css';
 
+import { vueCssRules } from '@/rules';
+
 const vueCssConfig: StylelintConfig = {
   ...cssConfig,
   overrides: [
diff --git a/packages/stylelint-config/src/types/stylelintConfig.ts b/packages/stylelint-config/src/types/stylelintConfig.ts
@@ -1,4 +1,4 @@
-import { Config } from 'stylelint';
+import type { Config } from 'stylelint';
 
 type BaseConfig = Omit<Config, 'overrides' | 'extends'>;
 
diff --git a/packages/stylelint-config/src/utils/orderRuleCreators.ts b/packages/stylelint-config/src/utils/orderRuleCreators.ts
@@ -1,4 +1,4 @@
-import {
+import type {
   EmptyLineBeforeOption,
   OrderAtRule,
   OrderRule,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { type FlatConfigArray } from '@/types';`
	`1`	`+import type { FlatConfigArray } from '@/types';`
`2`	`2`
`3`	`3`	`import baseConfig from '@/configs/base';`
`4`	`4`	`import prettierConfig from '@/configs/prettier';`