Skip to content

Commit 066da57

Browse files
committed
fix: if value-type condition before switch case
1 parent a4b5f42 commit 066da57

File tree

1 file changed

+47
-45
lines changed

1 file changed

+47
-45
lines changed

src/getValue.js

Lines changed: 47 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -95,51 +95,53 @@ const getValue = (element) => {
9595
// value = value.substring(11, 8) + 'Z';
9696
value = value.substring(11, 19) + "Z";
9797

98-
switch (valueType) {
99-
case "getDayName":
100-
const days = [
101-
"Sunday",
102-
"Monday",
103-
"Tuesday",
104-
"Wednesday",
105-
"Thursday",
106-
"Friday",
107-
"Saturday"
108-
];
109-
value = days[value.getDay()];
110-
break;
111-
case "getMonthName":
112-
const months = [
113-
"January",
114-
"February",
115-
"March",
116-
"April",
117-
"May",
118-
"June",
119-
"July",
120-
"August",
121-
"September",
122-
"October",
123-
"November",
124-
"December"
125-
];
126-
value = months[value.getMonth()];
127-
break;
128-
case "toUnixTimestamp":
129-
value = Math.floor(value.getTime() / 1000);
130-
break;
131-
case "toLocaleString":
132-
let locale = element.getAttribute("locale") || "en-US";
133-
value = value[valueType](locale);
134-
break;
135-
default:
136-
if (typeof value[valueType] === "function") {
137-
value = value[valueType]();
138-
} else {
139-
console.warn(
140-
`The method ${valueType} is not a function of Date object.`
141-
);
142-
}
98+
if (valueType) {
99+
switch (valueType) {
100+
case "getDayName":
101+
const days = [
102+
"Sunday",
103+
"Monday",
104+
"Tuesday",
105+
"Wednesday",
106+
"Thursday",
107+
"Friday",
108+
"Saturday"
109+
];
110+
value = days[value.getDay()];
111+
break;
112+
case "getMonthName":
113+
const months = [
114+
"January",
115+
"February",
116+
"March",
117+
"April",
118+
"May",
119+
"June",
120+
"July",
121+
"August",
122+
"September",
123+
"October",
124+
"November",
125+
"December"
126+
];
127+
value = months[value.getMonth()];
128+
break;
129+
case "toUnixTimestamp":
130+
value = Math.floor(value.getTime() / 1000);
131+
break;
132+
case "toLocaleString":
133+
let locale = element.getAttribute("locale") || "en-US";
134+
value = value[valueType](locale);
135+
break;
136+
default:
137+
if (typeof value[valueType] === "function") {
138+
value = value[valueType]();
139+
} else {
140+
console.warn(
141+
`The method ${valueType} is not a function of Date object.`
142+
);
143+
}
144+
}
143145
}
144146
}
145147
} else if (element.tagName == "INPUT" || element.tagName == "SELECT") {

0 commit comments

Comments
 (0)