Remove dependency on EditorScriptingUtilities plugin in the metadata-textures branch #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @kring!
Reviewers, don't forget to make sure that:
|
Using the technique described in the comments above the UE_DEPRECATED macro.
Contributor
|
Thanks for looking into this @kring, the stale material issue I was worried about does not seem to appear even without auto-saving the material! So any open material editor is automatically updated after the regeneration (really it's closed and reopened). It's probably better not to save anyways, that should be up to the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #698. The reason Travis CI fails in that branch is because our dodgy cut down distribution of Unreal Engine doesn't include a bunch of plugins, including EditorScriptingUtilities. But it's relatively easy to remove the dependency in this case, so that's what I've done.
I also removed the code that saves the generated material. I think it's fine to let the Editor consider it unsaved, and to let the user save in the normal way if they would like to do so. But maybe there's a more subtle reason it was necessary to save it explicitly? Everything seemed to work ok, but it's possible I missed something.