Revert "Experiment to use REST instead of Form endpoints"

This reverts commit dbd86ab.

Author: Ceredron

src/Altinn.App.Core/Features/Correspondence/CorrespondenceClient.cs

@@ -1,13 +1,11 @@
 using System.Diagnostics;
 using System.Net;
 using System.Net.Http.Headers;
-using System.Net.Http.Json;
 using System.Text.Json;
 using Altinn.App.Core.Configuration;
 using Altinn.App.Core.Constants;
 using Altinn.App.Core.Features.Correspondence.Exceptions;
 using Altinn.App.Core.Features.Correspondence.Models;
-using Altinn.App.Core.Features.Correspondence.Models.Response;
 using Altinn.App.Core.Models;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Logging;
@@ -52,57 +50,6 @@ public async Task<SendCorrespondenceResponse> Send(
 
         try
         {
-            if (
-                payload.CorrespondenceRequest.Content.Attachments.Count > 0
-                && payload.CorrespondenceRequest.Content.Attachments.All(a => a is CorrespondenceStreamedAttachment)
-            )
-            {
-                var pollingJobs = new List<Task>();
-                var premadeAttachments = new List<Guid>();
-                foreach (
-                    CorrespondenceStreamedAttachment attachment in payload.CorrespondenceRequest.Content.Attachments
-                )
-                {
-                    var initializeAttachmentPayload = new AttachmentPayload
-                    {
-                        DisplayName = attachment.Filename,
-                        FileName = attachment.Filename,
-                        IsEncrypted = attachment.IsEncrypted ?? false,
-                        ResourceId = payload.CorrespondenceRequest.ResourceId,
-                        SendersReference = payload.CorrespondenceRequest.SendersReference + " - " + attachment.Filename,
-                    };
-                    var initializeAttachmentRequest = await AuthenticatedHttpRequestFactory(
-                        method: HttpMethod.Post,
-                        uri: GetUri("attachment"),
-                        content: JsonContent.Create(initializeAttachmentPayload),
-                        payload: payload
-                    );
-                    var initializeAttachmentResponse = await HandleServerCommunication<SendCorrespondenceResponse>(
-                        initializeAttachmentRequest,
-                        cancellationToken
-                    );
-                    var attachmentId = await initializeAttachmentRequest.Content.ReadAsStringAsync(cancellationToken);
-                    attachmentId = attachmentId.Trim('"');
-                    var attachmentDataContent = new StreamContent(attachment.Data);
-                    attachmentDataContent.Headers.ContentType = new MediaTypeHeaderValue("application/octet-stream");
-                    var uploadAttachmentRequest = await AuthenticatedHttpRequestFactory(
-                        method: HttpMethod.Post,
-                        uri: GetUri("attachment/upload"),
-                        content: attachmentDataContent,
-                        payload: payload
-                    );
-                    var uploadAttachmentResponse = await HandleServerCommunication<SendCorrespondenceResponse>(
-                        uploadAttachmentRequest,
-                        cancellationToken
-                    );
-                    if (Guid.TryParse(attachmentId, out var guidId))
-                    {
-                        pollingJobs.Add(PollAttachmentStatus(guidId, payload, cancellationToken));
-                    }
-                }
-                await Task.WhenAll(pollingJobs);
-                payload.CorrespondenceRequest.ExistingAttachments = premadeAttachments;
-            }
             using MultipartFormDataContent content = payload.CorrespondenceRequest.Serialise();
             using HttpRequestMessage request = await AuthenticatedHttpRequestFactory(
                 method: HttpMethod.Post,
@@ -141,55 +88,6 @@ CorrespondenceStreamedAttachment attachment in payload.CorrespondenceRequest.Con
         }
     }
 
-    /// <inheritdoc />
-    private async Task PollAttachmentStatus(
-        Guid attachmentId,
-        CorrespondencePayloadBase payload,
-        CancellationToken cancellationToken
-    )
-    {
-        const int maxAttempts = 3;
-        const int delaySeconds = 5;
-
-        for (int attempt = 1; attempt <= maxAttempts; attempt++)
-        {
-            await Task.Delay(TimeSpan.FromSeconds(delaySeconds), cancellationToken);
-
-            try
-            {
-                var statusResponse = await AuthenticatedHttpRequestFactory(
-                    method: HttpMethod.Get,
-                    uri: GetUri($"attachment/{attachmentId}"),
-                    content: null,
-                    payload: payload
-                );
-
-                var statusContent = await statusResponse.Content.ReadFromJsonAsync<AttachmentOverview>(
-                    cancellationToken
-                );
-                if (statusContent.Status == "Published")
-                {
-                    break;
-                }
-            }
-            catch (Exception ex)
-            {
-                // Log the exception
-                if (attempt == maxAttempts)
-                {
-                    // Handle or rethrow the exception after all attempts failed
-                    throw;
-                }
-            }
-            throw new CorrespondenceRequestException(
-                $"Failure when uploading attachment. Attachment was not published in time. ",
-                null,
-                HttpStatusCode.InternalServerError,
-                "Polling failed"
-            );
-        }
-    }
-
     /// <inheritdoc/>
     public async Task<GetCorrespondenceStatusResponse> GetStatus(
         GetCorrespondenceStatusPayload payload,

src/Altinn.App.Core/Features/Correspondence/Models/AttachmentPayload.cs

@@ -308,7 +308,7 @@ public sealed record CorrespondenceRequest : MultipartCorrespondenceItem
     /// <summary>
     /// Existing attachments that should be added to the correspondence.
     /// </summary>
-    public IReadOnlyList<Guid>? ExistingAttachments { get; set; }
+    public IReadOnlyList<Guid>? ExistingAttachments { get; init; }
 
     /// <summary>
     /// Serialises the entire <see cref="CorrespondenceRequest"/> object to a provided <see cref="MultipartFormDataContent"/> instance.

src/Altinn.App.Core/Features/Correspondence/Models/CorrespondenceRequest.cs

@@ -724,14 +724,6 @@ namespace Altinn.App.Core.Features.Correspondence
 }
 namespace Altinn.App.Core.Features.Correspondence.Models
 {
-    public sealed class AttachmentPayload : System.IEquatable<Altinn.App.Core.Features.Correspondence.Models.AttachmentPayload>
-    {
-        public AttachmentPayload() { }
-        public string? DisplayName { get; set; }
-        public string? FileName { get; set; }
-        public bool IsEncrypted { get; set; }
-        public string SendersReference { get; set; }
-    }
     public abstract class CorrespondenceAttachment : Altinn.App.Core.Features.Correspondence.Models.MultipartCorrespondenceItem, System.IEquatable<Altinn.App.Core.Features.Correspondence.Models.CorrespondenceAttachment>
     {
         protected CorrespondenceAttachment() { }
@@ -1017,7 +1009,7 @@ namespace Altinn.App.Core.Features.Correspondence.Models
         public required System.DateTimeOffset? AllowSystemDeleteAfter { get; init; }
         public required Altinn.App.Core.Features.Correspondence.Models.CorrespondenceContent Content { get; init; }
         public System.DateTimeOffset? DueDateTime { get; init; }
-        public System.Collections.Generic.IReadOnlyList<System.Guid>? ExistingAttachments { get; set; }
+        public System.Collections.Generic.IReadOnlyList<System.Guid>? ExistingAttachments { get; init; }
         public System.Collections.Generic.IReadOnlyList<Altinn.App.Core.Features.Correspondence.Models.CorrespondenceExternalReference>? ExternalReferences { get; init; }
         public bool? IgnoreReservation { get; init; }
         public bool? IsConfirmationNeeded { get; init; }
@@ -1139,19 +1131,6 @@ namespace Altinn.App.Core.Features.Correspondence.Models
         public required System.Collections.Generic.IReadOnlyList<Altinn.App.Core.Features.Correspondence.Models.CorrespondenceDetailsResponse> Correspondences { get; init; }
     }
 }
-namespace Altinn.App.Core.Features.Correspondence.Models.Response
-{
-    public class AttachmentOverview
-    {
-        public AttachmentOverview() { }
-        public System.Guid AttachmentId { get; set; }
-        public System.Collections.Generic.List<System.Guid> CorrespondenceIds { get; set; }
-        public string DataType { get; set; }
-        public string Status { get; set; }
-        public System.DateTimeOffset StatusChanged { get; set; }
-        public string StatusText { get; set; }
-    }
-}
 namespace Altinn.App.Core.Features.DataLists
 {
     public class DataListsFactory