Added attr support to quickcheck! macro. #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means it is now possible to do things like:
quickcheck! {
#[ignore]
fn prop(...) -> bool {
...
}
}
Owner
|
Ah this sounds like a good change! I don't think it's a breaking change. cc @bluss I think if you just add a test like this one that uses the |
This is done by writing a test with `assert!(false)` with the `#[should_panic]` attr attached. If the macro is working correctly, this test passes. If not, it fails.
Contributor
Author
|
@BurntSushi I had forgotten about the |
Owner
|
Ooo good idea! I'll wait a bit and see if @bluss wants to chime in but I think this otherwise good to go! Thanks so much! |
Contributor
|
The macro changes look good, I think it's a good idea too! |
Owner
|
Sweet off we go! |
Owner
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to
#[ignore]some of my quickcheck tests defined withquickcheck!because they're expensive and I don't want to run them every time in dev. This (short) PR adds that ability.I don't have tests for this, because I wasn't sure how to go about doing so. All existing tests pass, however.