Fix unsigned/signed comp warnings

Blake-Madden · Blake-Madden · commit 99b402bbff57 · 2025-03-18T12:37:29.000-04:00
diff --git a/tinyexpr.cpp b/tinyexpr.cpp
@@ -1974,7 +1974,7 @@ te_expr* te_parser::base(te_parser::state* theState)
             const bool varValid{ m_varFound };
             const std::set<te_variable>::const_iterator openingVar = m_currentVar;
             // load any parameters
-            int i{ 0 }; // NOLINT
+            std::decay<decltype(arity)>::type i{ 0 }; // NOLINT
             for (i = 0; i < arity; i++)
                 {
                 next_token(theState);
@@ -2432,7 +2432,7 @@ void te_parser::optimize(te_expr* texp)
         {
         const auto arity = get_arity(texp->m_value);
         bool known{ true };
-        for (int i = 0; i < arity; ++i)
+        for (std::decay<decltype(arity)>::type i = 0; i < arity; ++i)
             {
             if (texp->m_parameters[i] == nullptr)
                 {

Original file line number	Diff line number	Diff line change
`@@ -1974,7 +1974,7 @@ te_expr* te_parser::base(te_parser::state* theState)`
`1974`	`1974`	`const bool varValid{ m_varFound };`
`1975`	`1975`	`const std::set<te_variable>::const_iterator openingVar = m_currentVar;`
`1976`	`1976`	`// load any parameters`
`1977`		`- int i{ 0 }; // NOLINT`
	`1977`	`+ std::decay<decltype(arity)>::type i{ 0 }; // NOLINT`
`1978`	`1978`	`for (i = 0; i < arity; i++)`
`1979`	`1979`	`{`
`1980`	`1980`	`next_token(theState);`
`@@ -2432,7 +2432,7 @@ void te_parser::optimize(te_expr* texp)`
`2432`	`2432`	`{`
`2433`	`2433`	`const auto arity = get_arity(texp->m_value);`
`2434`	`2434`	`bool known{ true };`
`2435`		`- for (int i = 0; i < arity; ++i)`
	`2435`	`+ for (std::decay<decltype(arity)>::type i = 0; i < arity; ++i)`
`2436`	`2436`	`{`
`2437`	`2437`	`if (texp->m_parameters[i] == nullptr)`
`2438`	`2438`	`{`