fix: blast/hmmsearch and gff output #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This Pull request would fix a few minor issues with CRISPRidentify concerning the hmmsearch, blast and gff output.
hmmsearch was non-functional as the .hmm databases were removed when the conda environments were added. Additionally the creation of the tmp folder and subsequent working directory there did not account for the relative path change. Making it unable to call either the .hmm and blast database.
Also restored the GFF output to functionality and some minor calculation errors where inclusive calculations were performed twice (end - start +1). Causing spacer ends to overshoot repeat starts.
All commands concerning these changes were performed and caused no errors.
The corrections can be checked with the testinput NC_013216 where all change into Bona-fide from Possible and gain blast and hmm scores in most arrays.
Hope this helps