Merge pull request #3 from jkyberneees/populate-content-length-if-missing

Populate content-length header if missing

Author: jkyberneees

index.js

@@ -1,5 +1,7 @@
 const fastProxy = require('fast-proxy')
 const restana = require('restana')
+const pump = require('pump')
+const toArray = require('stream-to-array')
 
 const gateway = (opts) => {
   opts = Object.assign({
@@ -24,6 +26,7 @@ const gateway = (opts) => {
     // populating required NOOPS
     route.hooks = route.hooks || {}
     route.hooks.onRequest = route.hooks.onRequest || onRequestNoOp
+    route.hooks.onResponse = route.hooks.onResponse || onResponse
 
     // populating pathRegex if missing
     route.pathRegex = undefined === route.pathRegex ? opts.pathRegex : String(route.pathRegex)
@@ -52,5 +55,20 @@ const handler = (route, proxy) => async (req, res) => {
 }
 
 const onRequestNoOp = (req, res) => { }
+const onResponse = async (req, res, stream) => {
+  if (!res.hasHeader('content-length')) {
+    try {
+      const resBuffer = Buffer.concat(await toArray(stream))
+      res.statusCode = stream.statusCode
+      res.setHeader('content-length', '' + Buffer.byteLength(resBuffer))
+      res.end(resBuffer)
+    } catch (err) {
+      res.send(err)
+    }
+  } else {
+    res.statusCode = stream.statusCode
+    pump(stream, res)
+  }
+}
 
 module.exports = gateway

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "fast-gateway",
-  "version": "1.1.2",
+  "version": "1.2.0",
   "description": "A Node.js API Gateway for the masses!",
   "main": "index.js",
   "scripts": {
@@ -28,7 +28,8 @@
   "dependencies": {
     "fast-proxy": "^1.1.2",
     "http-cache-middleware": "^1.0.0",
-    "restana": "^3.1.1"
+    "restana": "^3.1.1",
+    "stream-to-array": "^2.3.0"
   },
   "devDependencies": {
     "chai": "^4.2.0",

package.json

@@ -230,7 +230,7 @@ describe('API Gateway', () => {
 
   it('POST /users/info - 404', async () => {
     await request(gateway)
-      .post('/users/find')
+      .post('/users/info')
       .expect(404)
   })