Fix for 5033 - MSI response json parse failure error code #5038
+93
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs:139
- Ensure that the error message is logged before throwing the exception to aid in debugging.
_requestContext.Logger.Error("[Managed Identity] MSI json response failed to parse. " + ex);
gladjohn
approved these changes
Dec 31, 2024
bgavrilMS
force-pushed
the
bogavril/5033
branch
3 times, most recently
from
34601dc to
093a2d7
Compare
|
Linking to #5016 |
bgavrilMS
force-pushed
the
bogavril/5033
branch
from
093a2d7 to
8d04e00
Compare
bgavrilMS
force-pushed
the
bogavril/5033
branch
from
e0c545c to
71c7ed3
Compare
bgavrilMS
force-pushed
the
bogavril/5033
branch
from
a278085 to
b930ed8
Compare
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Show resolved
Hide resolved
neha-bhargava
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5016
Changes proposed in this request
Testing
Performance impact
Documentation