Skip to content

Conversation

@karpikpl
Copy link

This PR introduces NCC to build distributable package, so that node_modules are no longer required in the repo.

It follows solution from https://github.com/Azure/login

@karpikpl
Copy link
Author

Just noticed it copies the work done in #425 with the main difference that I deleted old lib files

@josh-hemphill
Copy link

Rooting for this PR, seems the cleanest. Really need one to get merged since it makes it possible to use in GHE.
@karpikpl Any chance for an update of the fork to get the checks passing? In the hope that the maintainers will approve this. 🤞

@karpikpl
Copy link
Author

karpikpl commented Feb 5, 2025

Rooting for this PR, seems the cleanest. Really need one to get merged since it makes it possible to use in GHE. @karpikpl Any chance for an update of the fork to get the checks passing? In the hope that the maintainers will approve this. 🤞

I can try, it's been a while when I created it.
This is really needed because this action is very slow without it

@karpikpl
Copy link
Author

karpikpl commented Feb 5, 2025

Hey @kumaraksh1 @surenderssm would you be able to review this?

@surenderssm
Copy link
Member

Tagging @ShilpiRachna1 to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants