Skip to content

Updated node version to 20 as node 16 is deprecated #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 8, 2024
Merged

Updated node version to 20 as node 16 is deprecated #418

merged 5 commits into from
Apr 8, 2024

Conversation

@ShilpiRachna1
Copy link
Contributor

@ShilpiRachna1 ShilpiRachna1 commented Apr 8, 2024

  • Updated node version to 20 as node 16 is deprecated
  • Updated versions of dependencies to fix build and test breaks. Current versions of Typescript and Jest are not compatible with node20
  • Updated node_modules auto-generated by running npm install

Validation done:

  • Validated the changes by running the tests in the repo
  • Verified the fix end to end by deploying some sample applications (for nodejs, python, php) with GitHub Actions from this branch.

kumaraksh1
kumaraksh1 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@kumaraksh1 kumaraksh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

surenderssm
surenderssm approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@surenderssm surenderssm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@surenderssm surenderssm merged commit de617f4 into releases/v3 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@surenderssm surenderssm surenderssm approved these changes

@kumaraksh1 kumaraksh1 kumaraksh1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShilpiRachna1 @surenderssm @kumaraksh1 @ShilpiR