Moving setresourcedetails into Publish profile container (#47)

* change in validation factory

* Update ValidatorFactory.js

* fix for runtime os

* update error log

* updated error log

Author: aksm-ms

lib/ActionInputValidator/ValidatorFactory.js

@@ -29,8 +29,8 @@ class ValidatorFactory {
         return __awaiter(this, void 0, void 0, function* () {
             let actionParams = actionparameters_1.ActionParameters.getActionParams();
             if (type === BaseWebAppDeploymentProvider_1.DEPLOYMENT_PROVIDER_TYPES.PUBLISHPROFILE) {
-                yield this.setResourceDetails(actionParams);
                 if (!!actionParams.images) {
+                    yield this.setResourceDetails(actionParams);
                     return new PublishProfileContainerWebAppValidator_1.PublishProfileContainerWebAppValidator();
                 }
                 else {

lib/Utilities/PublishProfile.js

@@ -62,7 +62,7 @@ class PublishProfile {
                 }
             }
             catch (error) {
-                throw Error("Internal Server Error. Please try again\n" + error);
+                throw Error("Failed to get app runtime OS\n" + JSON.stringify(error));
             }
             return this._appOS;
         });

src/ActionInputValidator/ValidatorFactory.ts

@@ -17,8 +17,8 @@ export class ValidatorFactory {
     public static async getValidator(type: DEPLOYMENT_PROVIDER_TYPES) : Promise<IValidator> {
         let actionParams: ActionParameters = ActionParameters.getActionParams();
         if(type === DEPLOYMENT_PROVIDER_TYPES.PUBLISHPROFILE) {
-            await this.setResourceDetails(actionParams);
             if (!!actionParams.images) {
+                await this.setResourceDetails(actionParams);
                 return new PublishProfileContainerWebAppValidator();
             }
             else {

src/Utilities/PublishProfile.ts

@@ -65,7 +65,7 @@ export class PublishProfile {
                 core.debug(`App Runtime OS: ${this._appOS}`);
             }
         } catch(error) {
-            throw Error("Internal Server Error. Please try again\n" + error);
+            throw Error("Failed to get app runtime OS\n" + JSON.stringify(error));
         }
         return this._appOS;
     }