Skip to content

FormatTimesForSASSigning should convert to UTC before formatting #170

@someone1

Description

@someone1

Which version of the SDK was used?

v0.8.0

Which platform are you using? (ex: Windows, Linux, Debian)

Arch Linux

What problem was encountered?

Passing in time.Now().Add(time.Hour) to BlobSASSignatureValues.ExpiryTime results in the time string dropping TZ data and assuming it's in UTC. My local is in EST but the format string omits any Time Zone addition with a static Z ending: 2006-01-02T15:04:05Z

How can we reproduce the problem in the simplest way?

https://play.golang.org/p/YB02MQG3m1T

Something like

azblob.FormatTimesForSASSigning(time.Now().In(time.FixedZone("UTC-8", -8*60*60), time.Time{}, time.TIme{})

It should be an easy fix - could have saved me a load of hours as I saw the time format with a Z ending in the encoded query and assumed it was properly converting to UTC (didn't pay close enough attention to the actual numbers though)

Have you found a mitigation/solution?

Pass in the time values in the struct as UTC myself

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions