Upgrade linting version (#2105)

Author: gapra-msft

.github/workflows/golangci-lint.yml

@@ -16,20 +16,20 @@ jobs:
   golangci:
     strategy:
       matrix:
-        go: [1.17]
+        go: [1.18]
         os: [ubuntu-latest, windows-latest, macos-latest]
     name: lint
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/setup-go@v3
         with:
           go-version: ${{ matrix.go }}
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.46
+          version: latest
           # Optional: working directory, useful for monorepos
           # working-directory: somedir
 

cmd/copyEnumeratorInit.go

@@ -614,11 +614,6 @@ func (cca *CookedCopyCmdArgs) MakeEscapedRelativePath(source bool, dstIsDir bool
 		return pathEncodeRules(relativePath, cca.FromTo, cca.disableAutoDecoding, source)
 	}
 
-	// user is not placing the source as a subdir
-	if object.isSourceRootFolder() && !asSubdir {
-		relativePath = ""
-	}
-
 	// If it's out here, the object is contained in a folder, or was found via a wildcard, or object.isSourceRootFolder == true
 	if object.isSourceRootFolder() {
 		relativePath = "" // otherwise we get "/" from the line below, and that breaks some clients, e.g. blobFS

testSuite/scripts/utility.py

@@ -100,7 +100,7 @@ def execute_azcopy_info(self):
     def execute_testsuite_upload(self):
         return verify_operation(self.string())
 
-# processes oauth command according to swtiches
+# processes oauth command according to switches
 def process_oauth_command(
     cmd,
     fromTo=""):