Skip to content

Commit 1a226db

Browse files
[azsystemevents] Regenerate based on latest update (adding in storage tiers to some system events) (#23269)
Some other changes have come along for the ride or been implemented: - Removal of types that were only used as base properties for events, but were not system events on their own. These were things like `ACSChatThreadEventInThreadBaseProperties`. Our generator handles this by just inlining those properties into the child "classes", so the base struct is just vestigial (except in a few cases where the base type is actually a system event). - Updated to proper hash from main.
1 parent 5d36e38 commit 1a226db

File tree

13 files changed

+353
-967
lines changed

13 files changed

+353
-967
lines changed

sdk/messaging/eventgrid/azsystemevents/CHANGELOG.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
# Release History
22

3-
## 0.4.1 (Unreleased)
3+
## 0.4.1 (2024-08-20)
44

55
### Features Added
66

7-
### Breaking Changes
7+
- New fields have been added:
8+
- StorageBlobCreatedEventData: AccessTier
9+
- StorageBlobTierChangedEventData: AccessTier and PreviousTier
810

9-
### Bugs Fixed
11+
### Breaking Changes
1012

11-
### Other Changes
13+
- Models that were not system events (ex: ACSChatMessageEventInThreadBaseProperties), or referenced by system events, have been removed.
1214

1315
## 0.4.0 (2024-06-11)
1416

sdk/messaging/eventgrid/azsystemevents/constants.go

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/messaging/eventgrid/azsystemevents/internal/generate/generate.go

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,28 @@ func deleteUnneededFiles() {
137137

138138
func doRemove() error {
139139
modelsToRemove := []string{
140-
// these are not events, themselves, but are just contained within
141-
// other events.
140+
// These types are base objects of some of our system events in the TypeSpec, giving them a simple way to share fields.
141+
// Our generator handles this parent/child relationship by just inlining those properties into the children, so the base struct is just vestigial.
142+
// Note that these have been annotated with @output, which is why they're not just clipped out using our normal "unused/unreferenced" type logic
143+
// in the Go emitter.
144+
"ACSChatEventBaseProperties",
145+
"ACSChatEventInThreadBaseProperties",
146+
"ACSChatMessageEventBaseProperties",
147+
"ACSChatMessageEventInThreadBaseProperties",
148+
"ACSChatThreadEventBaseProperties",
149+
"ACSChatThreadEventInThreadBaseProperties",
150+
"ACSRouterEventData",
151+
"ACSRouterJobEventData",
152+
"ACSRouterWorkerEventData",
153+
"ACSSmsEventBaseProperties",
154+
"AppConfigurationSnapshotEventData",
142155
"AVSClusterEventData",
143156
"AVSPrivateCloudEventData",
144157
"AVSScriptExecutionEventData",
158+
"ContainerServiceClusterSupportEventData",
159+
"ContainerServiceNodePoolRollingEventData",
160+
"ResourceNotificationsResourceDeletedEventData",
161+
"ResourceNotificationsResourceUpdatedEventData",
145162
}
146163

147164
for _, m := range modelsToRemove {

0 commit comments

Comments
 (0)