Skip to content

Commit 0dbf18b

Browse files
committed
feedback + PR template
1 parent c581d84 commit 0dbf18b

File tree

3 files changed

+29
-11
lines changed

3 files changed

+29
-11
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,33 @@ This checklist is used to make sure that common issues in a pull request are add
1212
This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
1313
-->
1414

15-
### PR information
16-
<!-- You can mark the following checkboxes as [x] to mark them during the PR creation itself. -->
17-
- [ ] The title of the PR is clear and informative.
18-
- [ ] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).
19-
- [ ] If applicable, the PR references the bug/issue that it fixes in the description.
20-
- [ ] New Unit tests were added for the changes made and CI is passing.
21-
22-
### Quality of Code and Contribution Guidelines
23-
- [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-functions-python-worker/blob/master/.github/CONTRIBUTING.md).
15+
## Pull Request Checklist
16+
<!--
17+
Please fill out the following checklist to ensure compatibility across Python versions and programming models.
18+
You can mark the following checkboxes as [x] to mark them during the PR creation itself.
19+
-->
20+
### Host-Worker Contract
21+
- [ ] Does this PR impact the host-worker contract (e.g., gRPC messages, shared interfaces)?
22+
- If yes, have the changes been applied to:
23+
- [ ] azure_functions_worker (Python <= 3.12)
24+
- [ ] proxy_worker (Python >= 3.13)
25+
- If no, please explain why:
26+
27+
### Worker Execution Logic
28+
- [ ] Does this PR affect worker execution logic (e.g., function invocation, bindings, lifecycle)?
29+
If yes, please answer the following:
30+
31+
**Python Version Coverage**
32+
- [ ] Does this change apply to both Python <=3.12 and 3.13+?
33+
- If yes, have the changes been made to:
34+
- [ ] azure_functions_worker (Python <= 3.12)
35+
- [ ] azure_functions_worker_v1 / azure_functions_worker_v2 (Python >= 3.13)
36+
- If no, please explain why:
37+
38+
**Programming Model Compatibility (for Python 3.13+)**
39+
- Does this change apply to both:
40+
- [ ] V1 programming model (azure_functions_worker_v1)?
41+
- [ ] V2 programming model (azure_functions_worker_v2)?
42+
- Explanation (if limited to one model):
2443

2544
<!-- Thanks for using the checklist -->

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ py3env/
105105
*.nupkg
106106

107107
.testconfig
108-
/*/.testconfig
108+
*/.testconfig
109109
.pytest_cache
110110

111111
# vscode

workers/tests/endtoend/dependency_isolation_functions/report_dependencies/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,4 @@ def main(req: func.HttpRequest) -> func.HttpResponse:
4848
"HOST_VERSION": os.getenv('HOST_VERSION')
4949
}
5050
}
51-
logging.info("Dependency report: %s", json.dumps(result))
5251
return func.HttpResponse(json.dumps(result))

0 commit comments

Comments
 (0)