Skip to content

Commit 7cf1eb1

Browse files
authored
Remove workerId from error logs (#657)
1 parent 45865da commit 7cf1eb1

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/Worker.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ export function startNodeWorker(args) {
5757
const error = ensureErrorType(err);
5858
let errorMessage: string;
5959
if (error.isAzureFunctionsSystemError) {
60-
errorMessage = `Worker ${workerId} uncaught exception: ${error.stack || err}`;
60+
errorMessage = `Worker uncaught exception: ${error.stack || err}`;
6161
} else {
62-
errorMessage = `Worker ${workerId} uncaught exception (learn more: https://go.microsoft.com/fwlink/?linkid=2097909 ): ${
62+
errorMessage = `Worker uncaught exception (learn more: https://go.microsoft.com/fwlink/?linkid=2097909 ): ${
6363
error.stack || err
6464
}`;
6565
}

src/setupEventStream.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function setupEventStream(channel: WorkerChannel): void {
2828
});
2929

3030
channel.eventStream.on('error', function (err) {
31-
systemError(`Worker ${channel.workerId} encountered event stream error: `, err);
31+
systemError(`Worker encountered event stream error: `, err);
3232
throw new AzFuncSystemError(err);
3333
});
3434

@@ -37,7 +37,7 @@ export function setupEventStream(channel: WorkerChannel): void {
3737
channel.eventStream.write = function checkWrite(msg) {
3838
const msgError = rpc.StreamingMessage.verify(msg);
3939
if (msgError) {
40-
systemError(`Worker ${channel.workerId} malformed message`, msgError);
40+
systemError(`Worker malformed message`, msgError);
4141
throw new AzFuncSystemError(msgError);
4242
}
4343
oldWrite.apply(channel.eventStream, [msg]);
@@ -89,7 +89,7 @@ async function handleMessage(channel: WorkerChannel, inMsg: rpc.StreamingMessage
8989
// Not yet implemented
9090
return;
9191
default:
92-
throw new AzFuncSystemError(`Worker ${channel.workerId} had no handler for message '${eventName}'`);
92+
throw new AzFuncSystemError(`Worker had no handler for message '${eventName}'`);
9393
}
9494

9595
request = nonNullProp(inMsg, eventName);

test/eventHandlers/FunctionEnvironmentReloadHandler.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export namespace Msg {
3535

3636
export const noHandlerRpcLog: rpc.IStreamingMessage = {
3737
rpcLog: {
38-
message: "Worker 00000000-0000-0000-0000-000000000000 had no handler for message 'undefined'",
38+
message: "Worker had no handler for message 'undefined'",
3939
level: LogLevel.Error,
4040
logCategory: LogCategory.System,
4141
},

0 commit comments

Comments
 (0)