chore: update to go1.24 (#3912)

* chore: update to go1.24

Signed-off-by: Evan Baker <[email protected]>

* chore: cleanup rebase

* chore: regenerate crds

* chore: address comments

* chore: clean up go tool cover

* chore: pre-review cleanup

* revert: ipv6 image from azurelinux to base

* chore: add back go-junit-report tool install

* chore: clean up cni non-constant Errorf usage

* chore: clean up cns non-constant Sprintf usage

* chore: clean up npm non-constant Sprintf usage

* chore: clean up test non-constant Errorf usage

* chore: cleanup windows NPM

* chore: generate bpf-lib(s) for block-iptables in signed UTs

* chore: cleanup rebase

---------

Signed-off-by: Evan Baker <[email protected]>
Co-authored-by: Evan Baker <[email protected]>

Author: jpayne3506

.devcontainer/Dockerfile

@@ -1,4 +1,4 @@
-ARG VARIANT="1.23"
+ARG VARIANT="1.24"
 FROM mcr.microsoft.com/vscode/devcontainers/go:${VARIANT}
 RUN apt-get update && \
     export DEBIAN_FRONTEND=noninteractive && \
@@ -8,4 +8,6 @@ RUN apt-get update && \
     skopeo \
     vim \
     fzf \
-    ripgrep
+    ripgrep \
+    jq \
+    curl

.devcontainer/devcontainer.json

@@ -5,7 +5,7 @@
 	"build": {
 		"dockerfile": "Dockerfile",
 		"args": {
-			"VARIANT": "1.23-bullseye",
+			"VARIANT": "1.24",
 			"NODE_VERSION": "none"
 		}
 	},

.github/dependabot.yaml

@@ -62,27 +62,6 @@ updates:
       versions: [">=0.35.0"]
     - dependency-name: "k8s.io/kubectl"
       versions: [">=0.35.0"]
-- package-ecosystem: "gomod"
-  directory: "/build/tools"
-  schedule:
-    interval: "daily"
-  commit-message:
-    prefix: "deps"
-  labels: [ "dependencies" ]
-  open-pull-requests-limit: 10
-  ignore:
-    - dependency-name: "k8s.io/api"
-      versions: [">=0.35.0"]
-    - dependency-name: "k8s.io/apiextensions-apiserver"
-      versions: [">=0.35.0"]
-    - dependency-name: "k8s.io/apimachinery"
-      versions: [">=0.35.0"]
-    - dependency-name: "k8s.io/client-go"
-      versions: [">=0.35.0"]
-    - dependency-name: "k8s.io/kubelet"
-      versions: [">=0.35.0"]
-    - dependency-name: "k8s.io/kubectl"
-      versions: [">=0.35.0"]
 - package-ecosystem: "gomod"
   directory: "/dropgz"
   schedule:

.github/workflows/baseimages.yaml

@@ -18,10 +18,12 @@ jobs:
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - name: Set up Go
-      uses: actions/setup-go@v5
+    - uses: actions/setup-go@v5
       with:
-        go-version: '1.23'
+        go-version-file: go.mod
+    - name: go env
+      run: |
+        echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV
     - name: Render Dockerfiles
       run: make dockerfiles
     - name: Fail if base images are outdated

.github/workflows/codeql.yaml

@@ -32,13 +32,12 @@ jobs:
       contents: read
       security-events: write
     steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
       - name: Setup go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23"
-          check-latest: true
-      - name: Checkout repository
-        uses: actions/checkout@v4
+          go-version-file: go.mod
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v3
         with:

.github/workflows/crdgen.yaml

@@ -12,19 +12,15 @@ on:
       - checks_requested
 jobs:
   crdgen:
-    strategy:
-      matrix:
-        go-version: ['1.22', '1.23']
-        os: [ubuntu-latest]
     name: CRDs are Generated
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - uses: actions/setup-go@v5
       with:
-        go-version: ${{ matrix.go-version }}
+        go-version-file: go.mod
     - name: Regenerate NodeNetworkConfig CRD
       run: make -C crd/nodenetworkconfig
     - name: Regenerate MultitenantNetworkContainer CRD
@@ -36,4 +32,8 @@ jobs:
     - name: Regenerate OverlayExtensionConfig CRD
       run: make -C crd/overlayextensionconfig
     - name: Fail if the tree is dirty
-      run: test -z "$(git status --porcelain)"
+      run: |
+        if [ -n "$(git status --porcelain)" ]; then
+          echo "Changes detected. Please run 'make regenerate-crd' locally to regenerate crds."
+          exit 1
+        fi

.github/workflows/cyclonus-netpol-extended-nightly-test.yaml

@@ -26,7 +26,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version-file: go.mod
 
       - name: Setup Kind
         uses: helm/kind-action@v1

.github/workflows/cyclonus-netpol-test.yaml

@@ -33,7 +33,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: '^1.23'
+          go-version-file: go.mod
 
       - name: Setup Kind
         uses: helm/kind-action@v1

.github/workflows/golangci.yaml

@@ -34,18 +34,17 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go-version: ['1.22.x', '1.23.x']
         os: [ubuntu-latest, windows-latest]
     name: Lint
     needs: generate
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/setup-go@v5
-      with:
-        go-version: ${{ matrix.go-version }}
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0
+    - uses: actions/setup-go@v5
+      with:
+        go-version-file: go.mod
     - name: Download generated code
       uses: actions/download-artifact@v4
       with:
@@ -54,5 +53,5 @@ jobs:
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v6
       with:
-        version: v1.61
-        args: ${{ github.event_name == 'pull_request' && format('--new-from-rev=origin/{0}', github.base_ref) || '' }} --config=.golangci.yml --timeout=25m 
+        version: latest
+        args: ${{ github.event_name == 'pull_request' && format('--new-from-rev=origin/{0}', github.base_ref) || '' }} --config=.golangci.yml --timeout=25m

.gitignore

@@ -25,7 +25,6 @@ ipam-*.xml
 *.test
 
 controller-gen
-build/tools/bin
 npm/debug/http
 
 go.work*