Skip to content

Commit 373b503

Browse files
authored
Fix more CA/SA warnings (#1938)
Fix SA1113/CA1200/SA1805/SA1629/SA1407/SA1127 warnings.
1 parent 0719338 commit 373b503

25 files changed

+149
-88
lines changed

src/Polly/Bulkhead/BulkheadRejectedException.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,17 @@ public class BulkheadRejectedException : ExecutionRejectedException
1616
/// <summary>
1717
/// Initializes a new instance of the <see cref="BulkheadRejectedException" /> class.
1818
/// </summary>
19-
public BulkheadRejectedException() : this("The bulkhead semaphore and queue are full and execution was rejected.")
19+
public BulkheadRejectedException()
20+
: this("The bulkhead semaphore and queue are full and execution was rejected.")
2021
{
2122
}
2223

2324
/// <summary>
2425
/// Initializes a new instance of the <see cref="BulkheadRejectedException"/> class.
2526
/// </summary>
2627
/// <param name="message">The message.</param>
27-
public BulkheadRejectedException(string message) : base(message)
28+
public BulkheadRejectedException(string message)
29+
: base(message)
2830
{
2931
}
3032

@@ -33,7 +35,8 @@ public BulkheadRejectedException(string message) : base(message)
3335
/// </summary>
3436
/// <param name="message">The message.</param>
3537
/// <param name="innerException">The inner exception.</param>
36-
public BulkheadRejectedException(string message, Exception innerException) : base(message, innerException)
38+
public BulkheadRejectedException(string message, Exception innerException)
39+
: base(message, innerException)
3740
{
3841
}
3942

@@ -44,7 +47,8 @@ public BulkheadRejectedException(string message, Exception innerException) : bas
4447
/// </summary>
4548
/// <param name="info">The information.</param>
4649
/// <param name="context">The context.</param>
47-
protected BulkheadRejectedException(SerializationInfo info, StreamingContext context) : base(info, context)
50+
protected BulkheadRejectedException(SerializationInfo info, StreamingContext context)
51+
: base(info, context)
4852
{
4953
}
5054
#endif

src/Polly/Caching/AbsoluteTtl.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ public class AbsoluteTtl : NonSlidingTtl
1010
/// Initializes a new instance of the <see cref="AbsoluteTtl"/> class.
1111
/// </summary>
1212
/// <param name="absoluteExpirationTime">The UTC point in time until which to consider the cache item valid.</param>
13-
public AbsoluteTtl(DateTimeOffset absoluteExpirationTime) : base(absoluteExpirationTime)
13+
public AbsoluteTtl(DateTimeOffset absoluteExpirationTime)
14+
: base(absoluteExpirationTime)
1415
{
1516
}
1617
}

src/Polly/Caching/Ttl.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ public struct Ttl
2121
/// </summary>
2222
/// <param name="timeSpan">The timespan for which this cache-item remains valid.
2323
/// <remarks>Will be considered as not denoting sliding expiration.</remarks></param>
24-
public Ttl(TimeSpan timeSpan) : this(timeSpan, false)
24+
public Ttl(TimeSpan timeSpan)
25+
: this(timeSpan, false)
2526
{
2627
}
2728

src/Polly/CircuitBreaker/AdvancedCircuitController.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ public AdvancedCircuitController(
1717
Action<DelegateResult<TResult>, CircuitState, TimeSpan, Context> onBreak,
1818
Action<Context> onReset,
1919
Action onHalfOpen
20-
) : base(durationOfBreak, onBreak, onReset, onHalfOpen)
20+
)
21+
: base(durationOfBreak, onBreak, onReset, onHalfOpen)
2122
{
2223
_metrics = samplingDuration.Ticks < ResolutionOfCircuitTimer * NumberOfWindows
2324
? new SingleHealthMetrics(samplingDuration)

src/Polly/CircuitBreaker/AsyncCircuitBreakerPolicy.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ public class AsyncCircuitBreakerPolicy : AsyncPolicy, ICircuitBreakerPolicy
1010
internal AsyncCircuitBreakerPolicy(
1111
PolicyBuilder policyBuilder,
1212
ICircuitController<EmptyStruct> breakerController
13-
) : base(policyBuilder) =>
13+
)
14+
: base(policyBuilder) =>
1415
_breakerController = breakerController;
1516

1617
/// <summary>
@@ -64,7 +65,8 @@ public class AsyncCircuitBreakerPolicy<TResult> : AsyncPolicy<TResult>, ICircuit
6465
internal AsyncCircuitBreakerPolicy(
6566
PolicyBuilder<TResult> policyBuilder,
6667
ICircuitController<TResult> breakerController
67-
) : base(policyBuilder) =>
68+
)
69+
: base(policyBuilder) =>
6870
_breakerController = breakerController;
6971

7072
/// <summary>

src/Polly/CircuitBreaker/CircuitBreakerPolicy.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ public class CircuitBreakerPolicy : Policy, ICircuitBreakerPolicy
1010
internal CircuitBreakerPolicy(
1111
PolicyBuilder policyBuilder,
1212
ICircuitController<EmptyStruct> breakerController
13-
) : base(policyBuilder) =>
13+
)
14+
: base(policyBuilder) =>
1415
_breakerController = breakerController;
1516

1617
/// <summary>
@@ -62,7 +63,8 @@ public class CircuitBreakerPolicy<TResult> : Policy<TResult>, ICircuitBreakerPol
6263
internal CircuitBreakerPolicy(
6364
PolicyBuilder<TResult> policyBuilder,
6465
ICircuitController<TResult> breakerController
65-
) : base(policyBuilder) =>
66+
)
67+
: base(policyBuilder) =>
6668
_breakerController = breakerController;
6769

6870
/// <summary>

src/Polly/CircuitBreaker/ConsecutiveCountCircuitController.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ public ConsecutiveCountCircuitController(
1111
Action<DelegateResult<TResult>, CircuitState, TimeSpan, Context> onBreak,
1212
Action<Context> onReset,
1313
Action onHalfOpen
14-
) : base(durationOfBreak, onBreak, onReset, onHalfOpen) =>
14+
)
15+
: base(durationOfBreak, onBreak, onReset, onHalfOpen) =>
1516
_exceptionsAllowedBeforeBreaking = exceptionsAllowedBeforeBreaking;
1617

1718
public override void OnCircuitReset(Context context)

src/Polly/Context.Dictionary.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,12 @@ public partial class Context : IDictionary<string, object>, IDictionary, IReadOn
1818
/// </summary>
1919
/// <param name="operationKey">The operation key.</param>
2020
/// <param name="contextData">The context data.</param>
21-
public Context(string operationKey, IDictionary<string, object> contextData) : this(contextData) =>
21+
public Context(string operationKey, IDictionary<string, object> contextData)
22+
: this(contextData) =>
2223
OperationKey = operationKey;
2324

24-
internal Context(IDictionary<string, object> contextData) : this()
25+
internal Context(IDictionary<string, object> contextData)
26+
: this()
2527
{
2628
if (contextData == null) throw new ArgumentNullException(nameof(contextData));
2729
wrappedDictionary = new Dictionary<string, object>(contextData);

src/Polly/Fallback/AsyncFallbackPolicy.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ internal AsyncFallbackPolicy(
6161
PolicyBuilder<TResult> policyBuilder,
6262
Func<DelegateResult<TResult>, Context, Task> onFallbackAsync,
6363
Func<DelegateResult<TResult>, Context, CancellationToken, Task<TResult>> fallbackAction
64-
) : base(policyBuilder)
64+
)
65+
: base(policyBuilder)
6566
{
6667
_onFallbackAsync = onFallbackAsync ?? throw new ArgumentNullException(nameof(onFallbackAsync));
6768
_fallbackAction = fallbackAction ?? throw new ArgumentNullException(nameof(fallbackAction));

src/Polly/Fallback/FallbackPolicy.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ internal FallbackPolicy(
5757
PolicyBuilder<TResult> policyBuilder,
5858
Action<DelegateResult<TResult>, Context> onFallback,
5959
Func<DelegateResult<TResult>, Context, CancellationToken, TResult> fallbackAction
60-
) : base(policyBuilder)
60+
)
61+
: base(policyBuilder)
6162
{
6263
_onFallback = onFallback ?? throw new ArgumentNullException(nameof(onFallback));
6364
_fallbackAction = fallbackAction ?? throw new ArgumentNullException(nameof(fallbackAction));

0 commit comments

Comments
 (0)