Revert "Fix build"

This reverts commit c8d5744.

Author: Ceredron

src/Altinn.App.Core/Features/Correspondence/CorrespondenceClient.cs

@@ -191,11 +191,11 @@ CancellationToken cancellationToken
     )
     {
         using HttpClient client = _httpClientFactory.CreateClient();
-
+        
         // Configure HttpClient for large file uploads
         client.Timeout = TimeSpan.FromMinutes(30);
         client.DefaultRequestHeaders.ExpectContinue = false;
-
+        
         using HttpResponseMessage response = await client.SendAsync(request, cancellationToken);
         string responseBody = await response.Content.ReadAsStringAsync(cancellationToken);
 

test/Altinn.App.Core.Tests/Features/Correspondence/Builder/CorrespondenceBuilderTests.cs

@@ -199,7 +199,7 @@ public void Build_WithAllProperties_ShouldReturnValidCorrespondence()
                 {
                     Filename = data.attachments[1].filename,
                     SendersReference = data.attachments[1].sendersReference,
-                    Data = new MemoryStream(Encoding.UTF8.GetBytes(data.attachments[1].data)),
+                    Data = Encoding.UTF8.GetBytes(data.attachments[1].data),
                     DataLocationType = data.attachments[1].dataLocationType,
                     IsEncrypted = data.attachments[1].isEncrypted,
                 }
@@ -210,7 +210,7 @@ public void Build_WithAllProperties_ShouldReturnValidCorrespondence()
                     {
                         Filename = data.attachments[2].filename,
                         SendersReference = data.attachments[2].sendersReference,
-                        Data = new MemoryStream(Encoding.UTF8.GetBytes(data.attachments[2].data)),
+                        Data = Encoding.UTF8.GetBytes(data.attachments[2].data),
                         DataLocationType = data.attachments[2].dataLocationType,
                         IsEncrypted = data.attachments[2].isEncrypted,
                     },
@@ -274,7 +274,7 @@ public void Build_WithAllProperties_ShouldReturnValidCorrespondence()
             correspondence.Content.Attachments[i].SendersReference.Should().Be(data.attachments[i].sendersReference);
             correspondence.Content.Attachments[i].DataLocationType.Should().Be(data.attachments[i].dataLocationType);
             Encoding
-                .UTF8.GetString(Encoding.UTF8.GetBytes(data.attachments[i].data))
+                .UTF8.GetString(correspondence.Content.Attachments[i].Data.Span)
                 .Should()
                 .Be(data.attachments[i].data);
         }

test/Altinn.App.Core.Tests/Features/Correspondence/Models/CorrespondenceRequestTests.cs

@@ -42,13 +42,13 @@ public async Task Serialise_ShouldAddCorrectFields()
                     {
                         Filename = "filename-1",
                         SendersReference = "senders-reference-1",
-                        Data = new MemoryStream("data"u8.ToArray()),
+                        Data = "data"u8.ToArray(),
                     },
                     new CorrespondenceAttachment
                     {
                         Filename = "filename-2",
                         SendersReference = "senders-reference-2",
-                        Data = new MemoryStream("data"u8.ToArray()),
+                        Data = "data"u8.ToArray(),
                         DataLocationType = CorrespondenceDataLocationType.NewCorrespondenceAttachment,
                         IsEncrypted = true,
                     },
@@ -212,13 +212,13 @@ public async Task Serialise_ShouldAddCorrectFields_IsReservedOverridesIgnoreRese
                     {
                         Filename = "filename-1",
                         SendersReference = "senders-reference-1",
-                        Data = new MemoryStream("data"u8.ToArray()),
+                        Data = "data"u8.ToArray(),
                     },
                     new CorrespondenceAttachment
                     {
                         Filename = "filename-2",
                         SendersReference = "senders-reference-2",
-                        Data = new MemoryStream("data"u8.ToArray()),
+                        Data = "data"u8.ToArray(),
                         DataLocationType = CorrespondenceDataLocationType.NewCorrespondenceAttachment,
                         IsEncrypted = true,
                     },
@@ -376,13 +376,13 @@ public async Task Serialise_ShouldHandleClashingFilenames(string clashingFilenam
                     {
                         Filename = clashingFilename,
                         SendersReference = "senders-reference-1",
-                        Data = new MemoryStream(Encoding.UTF8.GetBytes("data-1")),
+                        Data = Encoding.UTF8.GetBytes("data-1"),
                     },
                     new CorrespondenceAttachment
                     {
                         Filename = clashingFilename,
                         SendersReference = "senders-reference-2",
-                        Data = new MemoryStream(Encoding.UTF8.GetBytes("data-2")),
+                        Data = Encoding.UTF8.GetBytes("data-2"),
                     },
                 ],
             },
@@ -400,7 +400,7 @@ public async Task Serialise_ShouldHandleClashingFilenames(string clashingFilenam
     public void Serialise_ClashingFilenames_ShouldUseReferenceComparison()
     {
         // Arrange
-        var data = new MemoryStream(Encoding.UTF8.GetBytes("data"));
+        ReadOnlyMemory<byte> data = Encoding.UTF8.GetBytes("data");
         List<CorrespondenceAttachment> identicalAttachments =
         [
             new CorrespondenceAttachment