Skip to content

Conversation

@djkapner
Copy link
Contributor

@djkapner djkapner commented Feb 25, 2021

Tests passing:

  • cloud ci
  • bamboo
  • bamboo nightly (2 failed, fixed locally)

Validation for rewards table:

from allensdk.brain_observatory.behavior.behavior_ophys_session import BehaviorOphysSession

bs = BehaviorOphysSession.from_lims(995280513)
print(bs.rewards.head())
   volume  timestamps  autorewarded
0   0.005   313.77275          True
1   0.005   331.78736          True
2   0.005   351.30325          True
3   0.005   362.56253          True
4   0.005   374.57222          True

Validation for licks table

print(bs.licks.head())
   timestamps  frame
0     8.74129    113
1     8.94148    125
2     9.17471    139
3    11.77682    295
4    15.16290    498

Validation for eye_tracking table

print(bs.eye_tracking.head())
       timestamps     cr_area      eye_area  ...  pupil_width  pupil_height  pupil_phi
frame                                        ...                                      
0         0.56207  115.637908  67646.821697  ...    68.146547     72.966538   0.066032
1         0.57353  117.025194  67869.446623  ...    67.734262     72.240309   0.172283
2         0.57545  107.573781  67942.492130  ...    68.316086     72.513558   0.033658
3         0.60897         NaN           NaN  ...    68.005698     73.963582   0.072744
4         0.64236         NaN           NaN  ...    68.815023     73.677158   0.100999

@djkapner djkapner force-pushed the 1919-time-column-names branch from 39cf224 to 12bca51 Compare February 25, 2021 18:26
@djkapner djkapner force-pushed the 1919-time-column-names branch from 6714237 to a51e609 Compare February 25, 2021 22:17
@njmei njmei self-requested a review February 25, 2021 22:32
Copy link
Contributor

@njmei njmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@djkapner djkapner merged commit afc0135 into rc/2.8.0 Feb 26, 2021
@djkapner djkapner deleted the 1919-time-column-names branch February 26, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants