Do not apply sanitization to root path when generating paths for downloaded assets in the cache folder #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loaded assets in the cache folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address issue #972
Application launched via a JNLP file will failed to start for user wtih certain characters in their home folder (e.g.
C:\Users\Foo_O'Bar), which is a legal path on Windows, but paths for downloaded asset are incorrectly sanitize asC:\Users\Foo_O_Barand the application then fails as it attempts to access content inC:\Users\Foo_O_Bar\...instead ofC:\Users\Foo_OBar...