From 69e5b77c70ab35f03d614e29382d8b3834bb399d Mon Sep 17 00:00:00 2001 From: Eric Smith Date: Thu, 11 Jun 2015 18:25:32 -0500 Subject: [PATCH 1/4] Add a readme. --- README.md | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 README.md diff --git a/README.md b/README.md new file mode 100644 index 0000000..31f30f3 --- /dev/null +++ b/README.md @@ -0,0 +1,67 @@ +# Hangman in Java - for code sparring. + +This program tries to solve a game of hangman. It doesn't do a very good job - it's your job to fork it and create a new solution for it. + +## How To + +Fork this repo then clone it. To run the tests: + +```bash +mvn test +``` + +Tough stuff. To run the program: + +```bash +mvn package +java -jar target/Hangman-1.jar +``` + +When you run the program you'll see something like this: + +```bash +Erics-MacBook-Pro:HangmanJava paytonrules$ java -jar target/Hangman-1.jar +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +Current Clue Is _ _ _ _ _ +com.hangman.Game Over +``` + +What this means is is that the clue length was five characters, and your player successfully guessed....nothing. To see why let's take a look at YourPlayer.java. + +```java +public class YourPlayer implements Player { + @Override + public char GetGuess(List clue) { + return 'a'; + } +} +``` + +That's right `YourPlayer` - regardless of the clue - will guess the letter `a`. If it got `a` right, it guessed `a`. Wrong? `a`. It's a pretty stupid player. + +So to complete this exercise you will need to delete return 'a' - and instead return better guesses. How? Well look the parameter: + +`List clue`. The clue is exactly what you're seeing on screen. It is an array of characters where the '_' character means that you haven't gotten that location correct yet. + +This stumps people so let's go through an example. Let's assume the secret word is "aaron". The first time GetGuess is called it will get: + +`['_', '_', '_', '_', '_']` + +`YourPlayer` will guess 'a'. The next time GuetGuess is called it will look like: + +`['a', 'a', '_', '_', '_']` + +Naturally `YourPlayer` will guess 'a' again, because it is stupid. To complete this exercise you need to make `YourPlayer` good at hangman. + +## Tips + +* Maybe keep track of what you've guessed. +* Vowels are good. +* Your testing WILL BE GRADED! From a4fdb7b7172150548a10ebcb73e78670d81fce9a Mon Sep 17 00:00:00 2001 From: Eric Smith Date: Thu, 11 Jun 2015 18:25:58 -0500 Subject: [PATCH 2/4] Add a test that clarifies that '_' is valid This stumps people. --- src/test/java/com/hangman/players/YourPlayerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/hangman/players/YourPlayerTest.java b/src/test/java/com/hangman/players/YourPlayerTest.java index bc92a3b..6324245 100644 --- a/src/test/java/com/hangman/players/YourPlayerTest.java +++ b/src/test/java/com/hangman/players/YourPlayerTest.java @@ -9,7 +9,7 @@ public class YourPlayerTest { public void AlwaysGuessA() { YourPlayer player = new YourPlayer(); - char guess = player.GetGuess(Arrays.asList('a', 'b', 'c')); + char guess = player.GetGuess(Arrays.asList('_', 'b', 'c')); assertEquals('a', guess); } From 0a01697bf96ab420679858db1737c5e245b7d84a Mon Sep 17 00:00:00 2001 From: Eric Smith Date: Fri, 12 Jun 2015 13:01:05 -0500 Subject: [PATCH 3/4] Dont timestmap reports --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index 117652a..25d43c1 100644 --- a/pom.xml +++ b/pom.xml @@ -39,6 +39,7 @@ com.hangman.players.* + false From e49bf794c64ec91ac47135a6c033804de181ec8d Mon Sep 17 00:00:00 2001 From: Mike Danaher Date: Fri, 12 Jun 2015 15:18:10 -0500 Subject: [PATCH 4/4] Player AI Implementation --- .../java/com/hangman/players/YourPlayer.java | 33 ++++++++++++++- .../com/hangman/players/YourPlayerTest.java | 40 +++++++++++++++++-- 2 files changed, 68 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/hangman/players/YourPlayer.java b/src/main/java/com/hangman/players/YourPlayer.java index f537169..2c1fcfe 100644 --- a/src/main/java/com/hangman/players/YourPlayer.java +++ b/src/main/java/com/hangman/players/YourPlayer.java @@ -1,13 +1,42 @@ package com.hangman.players; import com.hangman.Player; +import com.sun.org.apache.xerces.internal.impl.xs.util.LSInputListImpl; import java.util.Arrays; import java.util.LinkedList; import java.util.List; +import java.util.Random; public class YourPlayer implements Player { - @Override + + private List vowels = new LinkedList(Arrays.asList('e', 'a', 'i', 'o', 'u')); + private List consonants = new LinkedList(Arrays.asList('r', 's', 't', 'l', 'n', 'd', 'g', 'b', 'c', 'm', 'p', 'f', 'h', 'v', 'w', 'y', 'j', 'k', 'q', 'x', 'z')); + public char GetGuess(List clue) { - return 'a'; + return MakeEducatedGuess(clue); + } + + private int EmptySpaces(List clue) { + int spaces = 0; + + for(char i : clue) { + if (i == '_') { + spaces++; + } + } + return spaces; + } + + private char MakeEducatedGuess(List clue) { + Random randomizer = new Random(); + int spaces = EmptySpaces(clue); + + if (spaces == clue.size()) { + return vowels.remove(0); + } else if (spaces == clue.size() - 1) { + return vowels.remove(0); + } else { + return consonants.remove(randomizer.nextInt(consonants.size() -1)); + } } } diff --git a/src/test/java/com/hangman/players/YourPlayerTest.java b/src/test/java/com/hangman/players/YourPlayerTest.java index 6324245..df5c4df 100644 --- a/src/test/java/com/hangman/players/YourPlayerTest.java +++ b/src/test/java/com/hangman/players/YourPlayerTest.java @@ -2,15 +2,49 @@ import org.junit.Test; import java.util.Arrays; +import java.util.LinkedList; +import java.util.List; + import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotEquals; public class YourPlayerTest { + List vowels = new LinkedList(Arrays.asList('a', 'e', 'i', 'o', 'u')); + + @Test + public void DoesNotGuessAlreadyValidLetter() { + YourPlayer player = new YourPlayer(); + + char guess = player.GetGuess(Arrays.asList('_', '_', 'a')); + + assertNotEquals('a', guess); + } + + @Test + public void DoesNotGuessSameLetterTwice() { + YourPlayer player = new YourPlayer(); + + char firstGuess = player.GetGuess(Arrays.asList('_', '_', '_')); + char secondGuess = player.GetGuess(Arrays.asList('_', '_', firstGuess)); + + assertNotEquals(firstGuess, secondGuess); + } + + @Test + public void GuessVowelsFirst() { + YourPlayer player = new YourPlayer(); + + char firstGuess = player.GetGuess(Arrays.asList('_', '_', '_', '_', '_')); + + assertEquals(true, vowels.contains(firstGuess)); + } + @Test - public void AlwaysGuessA() { + public void GuessesConsonantAfterTwoCorrectVowels() { YourPlayer player = new YourPlayer(); - char guess = player.GetGuess(Arrays.asList('_', 'b', 'c')); + char nextGuess = player.GetGuess(Arrays.asList('_', 'a', 'i', '_', '_', '_')); - assertEquals('a', guess); + assertEquals(false, vowels.contains(nextGuess)); } }