Skip to content

Commit e2ba3a1

Browse files
akpm00sfrothwell
authored andcommitted
swap-add-block-io-poll-in-swapin-path-checkpatch-fixes
WARNING: function definition argument 'struct page *' should also have an identifier name torvalds#60: FILE: include/linux/swap.h:334: +extern int swap_readpage(struct page *, bool do_poll); WARNING: line over 80 characters torvalds#164: FILE: mm/swap_state.c:415: + struct vm_area_struct *vma, unsigned long addr, bool do_poll) total: 0 errors, 2 warnings, 140 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/swap-add-block-io-poll-in-swapin-path.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Shaohua Li <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 2864d28 commit e2ba3a1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

include/linux/swap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ extern void kswapd_stop(int nid);
331331
#include <linux/blk_types.h> /* for bio_end_io_t */
332332

333333
/* linux/mm/page_io.c */
334-
extern int swap_readpage(struct page *, bool do_poll);
334+
extern int swap_readpage(struct page *page, bool do_poll);
335335
extern int swap_writepage(struct page *page, struct writeback_control *wbc);
336336
extern void end_swap_bio_write(struct bio *bio);
337337
extern int __swap_writepage(struct page *page, struct writeback_control *wbc,

mm/swap_state.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ struct page *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
412412
* the swap entry is no longer in use.
413413
*/
414414
struct page *read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
415-
struct vm_area_struct *vma, unsigned long addr, bool do_poll)
415+
struct vm_area_struct *vma, unsigned long addr, bool do_poll)
416416
{
417417
bool page_was_allocated;
418418
struct page *retpage = __read_swap_cache_async(entry, gfp_mask,

0 commit comments

Comments
 (0)